Geo-Restore Instance database cmdlet #8493

lixiachena · 2019-02-06T22:31:03Z

Description

Design spec PR is https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/225

Using this cmdlet, customer can

Get geo-redundant backups on the managed instance.
Restore an instance database from a geo-redundant backup .

The changeset is adding 1 cmdlet and updating 1 cmdlet.

New cmdlet
Get-AzSqlInstanceDatabaseGeoBackup: get geo-redundant backups on the managed instance.
Changed cmdlet
Restore-AzSqlInstanceDatabase: restore an instance database from a geo-redundant backup with -FromGeoBackup parameter.

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate change log has been updated
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- the changes have gone through a cmdlet design review (Microsoft internal partners only)
- the cmdlet markdown files were generated using the platyPS module

Geo-Restore Instance Database cmdlet

change help files

Update one test

adxsdkps · 2019-02-06T22:34:20Z

Can one of the admins verify this patch?

vladimir-shcherbakov · 2019-02-07T01:53:46Z

@azuresdkci Add to whitelist

vladimir-shcherbakov · 2019-02-07T01:58:56Z

@azuresdkci Add to whitelist

vladimir-shcherbakov · 2019-02-07T01:59:23Z

@azuresdkci test this please

vladimir-shcherbakov · 2019-02-07T19:24:04Z

@lixiachena
Please resolve the merge conflict
ci-build failures reason could be found here

modify after syncing

pixia · 2019-02-11T21:00:05Z

src/Sql/Sql.Test/ScenarioTests/ManagedDatabaseCrudScenarioTests.ps1

+
+<#
+.SYNOPSIS
+	Tests Getting a managed database


update the SYNOPSIS

src/Sql/Sql.Test/ScenarioTests/ManagedDatabaseCrudScenarioTests.ps1

pixia · 2019-02-12T00:06:09Z

src/Sql/Sql.Test/ScenarioTests/ManagedDatabaseCrudScenarioTests.ps1

+	Assert-NotNull $all
+	if($all.Count -le 1)
+	{
+        throw "Should mget more than 1 backup geo backups"


typo: Should get

pixia · 2019-02-12T00:06:41Z

src/Sql/Sql.Test/ScenarioTests/ManagedDatabaseCrudScenarioTests.ps1

+{
+	# Setup
+    $rgName = "restore-rg"	
+	$managedInstanceName = "restorerunnermanagedserverwus"


Can we change server name?

pixia · 2019-02-12T00:09:37Z

...Sql.Test.ScenarioTests.ManagedDatabaseCrudScenarioTests/TestGetManagedDatabaseGeoBackup.json

+          "-1"
+        ]
+      },
+      "ResponseBody": "{\r\n  \"value\": [\r\n    {\r\n      \"properties\": {\r\n        \"lastAvailableBackupDate\": \"2019-02-02T15:26:04.6930711Z\"\r\n      },\r\n      \"id\": \"/subscriptions/a8c9a924-06c0-4bde-9788-e7b1370969e1/resourceGroups/restore-rg/providers/Microsoft.Sql/managedInstances/restorerunnermanagedserverwus/recoverableDatabases/sourceDb_recovered6\",\r\n      \"name\": \"sourceDb_recovered6\",\r\n      \"type\": \"Microsoft.Sql/managedInstances/recoverableDatabases\"\r\n    },\r\n    {\r\n      \"properties\": {\r\n        \"lastAvailableBackupDate\": \"2019-02-02T15:26:04.6930711Z\"\r\n      },\r\n      \"id\": \"/subscriptions/a8c9a924-06c0-4bde-9788-e7b1370969e1/resourceGroups/restore-rg/providers/Microsoft.Sql/managedInstances/restorerunnermanagedserverwus/recoverableDatabases/sourceDb_recovered4\",\r\n      \"name\": \"sourceDb_recovered4\",\r\n      \"type\": \"Microsoft.Sql/managedInstances/recoverableDatabases\"\r\n    },\r\n    {\r\n      \"properties\": {\r\n        \"lastAvailableBackupDate\": \"2019-02-02T15:26:04.6930711Z\"\r\n      },\r\n      \"id\": \"/subscriptions/a8c9a924-06c0-4bde-9788-e7b1370969e1/resourceGroups/restore-rg/providers/Microsoft.Sql/managedInstances/restorerunnermanagedserverwus/recoverableDatabases/sourceDb_recovered2\",\r\n      \"name\": \"sourceDb_recovered2\",\r\n      \"type\": \"Microsoft.Sql/managedInstances/recoverableDatabases\"\r\n    },\r\n    {\r\n      \"properties\": {\r\n        \"lastAvailableBackupDate\": \"2019-02-02T15:26:04.6930711Z\"\r\n      },\r\n      \"id\": \"/subscriptions/a8c9a924-06c0-4bde-9788-e7b1370969e1/resourceGroups/restore-rg/providers/Microsoft.Sql/managedInstances/restorerunnermanagedserverwus/recoverableDatabases/sourceDb_recovered1_recovered\",\r\n      \"name\": \"sourceDb_recovered1_recovered\",\r\n      \"type\": \"Microsoft.Sql/managedInstances/recoverableDatabases\"\r\n    },\r\n    {\r\n      \"properties\": {\r\n        \"lastAvailableBackupDate\": \"2019-02-02T15:26:04.6930711Z\"\r\n      },\r\n      \"id\": \"/subscriptions/a8c9a924-06c0-4bde-9788-e7b1370969e1/resourceGroups/restore-rg/providers/Microsoft.Sql/managedInstances/restorerunnermanagedserverwus/recoverableDatabases/sourceDb_recovered1\",\r\n      \"name\": \"sourceDb_recovered1\",\r\n      \"type\": \"Microsoft.Sql/managedInstances/recoverableDatabases\"\r\n    },\r\n    {\r\n      \"properties\": {\r\n        \"lastAvailableBackupDate\": \"2019-02-02T15:26:04.6930711Z\"\r\n      },\r\n      \"id\": \"/subscriptions/a8c9a924-06c0-4bde-9788-e7b1370969e1/resourceGroups/restore-rg/providers/Microsoft.Sql/managedInstances/restorerunnermanagedserverwus/recoverableDatabases/sourceDb\",\r\n      \"name\": \"sourceDb\",\r\n      \"type\": \"Microsoft.Sql/managedInstances/recoverableDatabases\"\r\n    }\r\n  ]\r\n}",


change restorerunnermanagedserverwus everywhere in this file to another server name

Update md file and test fiels

Added Example

Modify example

maddieclayton · 2019-02-12T18:13:46Z

@lixiachena Please check out the file here to fix your build: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell/10703/artifact/artifacts/ValidateHelpIssues.csv/*view*/

Update example

Regenerate restore-azsqlinstancedatabase.md

vladimir-shcherbakov · 2019-02-19T22:30:59Z

src/Sql/Sql.Test/ScenarioTests/ManagedDatabaseCrudScenarioTests.cs

@@ -63,5 +63,19 @@ public void TestRestoreManagedDatabase()
        {
            RunPowerShellTest("Test-RestoreManagedDatabase");
        }
+
+        [Fact(Skip = "Setup time is long (more than 10 hours)")]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]


If the test recorded - it should't take long to playback - so you don't need to skip it. If a test skipped it's in fact disabled.

vladimir-shcherbakov · 2019-02-19T22:31:16Z

src/Sql/Sql.Test/ScenarioTests/ManagedDatabaseCrudScenarioTests.cs

+
+        [Fact(Skip = "Setup time is long (more than 10 hours)")]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void TestGeoRestoreManagedDatabase()


the same comment.

vladimir-shcherbakov · 2019-02-19T23:43:24Z

src/Sql/Sql.Test/ScenarioTests/ManagedDatabaseCrudScenarioTests.ps1

+
+		# geo-restore managed database using piping
+		$restoredDb4 = Restore-AzSqlInstanceDatabase -FromGeoBackup -ResourceGroupName $rgName -InstanceName $managedInstanceName -Name $managedDatabaseName -TargetInstanceDatabaseName $targetManagedDatabaseName4 -TargetInstanceName $targetInstanceName -TargetResourceGroupName $targetRgName
+		Assert-NotNull $restoredDb4


Could you point me to where piping gets actually tested?

vladimir-shcherbakov · 2019-02-19T23:46:03Z

src/Sql/Sql/help/Restore-AzSqlInstanceDatabase.md

+PS C:\>$GeoBackup = Get-AzSqlInstanceDatabaseGeoBackup -ResourceGroupName "ResourceGroup01" -InstanceName "managedInstance1" -Name "Database01"
+PS C:\> Restore-AzSqlDatabase -FromGeoBackup -GeoBackupObject $GeoBackup -TargetInstanceDatabaseName "Database01_restored" -TargetInstanceName "managedInstance1" -TargetResourceGroupName "ResourceGroup02"
+```
+


I see no changes.

vladimir-shcherbakov · 2019-02-20T17:00:33Z

src/Sql/Sql/ManagedDatabase/Cmdlet/RestoreAzureSqlManagedDatabase.cs

@@ -149,13 +199,41 @@ public class RestoreAzureRmSqlManagedDatabase
            Position = 0,
            ValueFromPipelineByPropertyName = true,
            HelpMessage = "The resource id of instance database object to restore")]
+        [Parameter(ParameterSetName = GeoRestoreFromGeoBackupSetNameFromResourceIdParameterSet,
+            Mandatory = true,
+            HelpMessage = "The name of the target instance to restore to.")]
        [ValidateNotNullOrEmpty]


Please fix the HelpMessage value.

vladimir-shcherbakov · 2019-02-21T00:26:01Z

ci-build failed: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell/10857/artifact/msbuild.err/*view*/

lixiachena added 2 commits February 6, 2019 13:41

Geo-Restore Instance Database cmdlet

8dd38f1

Geo-Restore Instance Database cmdlet

change help files

ba055a1

change help files

lixiachena requested review from jaredmoo and pixia February 6, 2019 22:31

azuresdkci added the needs-review label Feb 6, 2019

Update ManagedDatabaseCrudScenarioTests.cs

71e1653

Update one test

vladimir-shcherbakov added the Merge Conflicts label Feb 7, 2019

vladimir-shcherbakov assigned lixiachena Feb 7, 2019

vladimir-shcherbakov added needs-revision and removed needs-review labels Feb 7, 2019

Merge branch 'master' into master

bec0514

lixiachena removed the Merge Conflicts label Feb 8, 2019

Update AzureSqlRecoverableManagedDatabaseCmdletBase.cs

07bc402

modify after syncing

pixia reviewed Feb 11, 2019

View reviewed changes

src/Sql/Sql.Test/ScenarioTests/ManagedDatabaseCrudScenarioTests.ps1 Outdated Show resolved Hide resolved

pixia reviewed Feb 12, 2019

View reviewed changes

lixiachena added 3 commits February 12, 2019 01:56

Update md file and test fiels

faa9032

Update md file and test fiels

Added Example

f147648

Added Example

Update Get-AzSqlInstanceDatabaseGeoBackup.md

18406f3

Modify example

Update Get-AzSqlInstanceDatabaseGeoBackup.md

7ac5840

Update example

pixia previously approved these changes Feb 13, 2019

View reviewed changes

Regenerate restore-azsqlinstancedatabase.md

2da0b9e

Regenerate restore-azsqlinstancedatabase.md

maddieclayton assigned vladimir-shcherbakov and unassigned lixiachena Feb 19, 2019

Merge branch 'master' into master

5b35b43

vladimir-shcherbakov suggested changes Feb 19, 2019

View reviewed changes

vladimir-shcherbakov assigned lixiachena and unassigned vladimir-shcherbakov Feb 19, 2019

vladimir-shcherbakov added needs-revision and removed needs-review labels Feb 19, 2019

address on comments

b360b15

vladimir-shcherbakov suggested changes Feb 20, 2019

View reviewed changes

Fix helpmessage and change test server/db name

689b1de

vladimir-shcherbakov previously approved these changes Feb 20, 2019

View reviewed changes

vladimir-shcherbakov unassigned lixiachena Feb 20, 2019

vladimir-shcherbakov added Waiting for CI and removed needs-revision labels Feb 20, 2019

Update ManagedDatabaseCrudScenarioTests.ps1

cc4afac

lixiachena dismissed vladimir-shcherbakov’s stale review via cc4afac February 20, 2019 20:10

maddieclayton added Sprint Candidate needs-review and removed Waiting for CI labels Feb 20, 2019

maddieclayton assigned vladimir-shcherbakov Feb 20, 2019

maddieclayton removed the Sprint Candidate label Feb 20, 2019

vladimir-shcherbakov assigned lixiachena and unassigned vladimir-shcherbakov Feb 21, 2019

vladimir-shcherbakov added needs-revision and removed needs-review labels Feb 21, 2019

Fix pb mode test errors

ed685c1

vladimir-shcherbakov approved these changes Feb 21, 2019

View reviewed changes

vladimir-shcherbakov merged commit 67b66d3 into Azure:master Feb 21, 2019

Geo-Restore Instance database cmdlet #8493

Geo-Restore Instance database cmdlet #8493

Uh oh!

Conversation

lixiachena commented Feb 6, 2019

Description

Checklist

Uh oh!

adxsdkps commented Feb 6, 2019

Uh oh!

vladimir-shcherbakov commented Feb 7, 2019

Uh oh!

vladimir-shcherbakov commented Feb 7, 2019

Uh oh!

vladimir-shcherbakov commented Feb 7, 2019

Uh oh!

vladimir-shcherbakov commented Feb 7, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maddieclayton commented Feb 12, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vladimir-shcherbakov commented Feb 21, 2019

Uh oh!

Uh oh!