Skip to content

EventHub: added new boolean property SkipEmptyArchives to CaptureDescription #8500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 11, 2019
Merged

EventHub: added new boolean property SkipEmptyArchives to CaptureDescription #8500

merged 3 commits into from
Feb 11, 2019

Conversation

v-Ajnava
Copy link

@v-Ajnava v-Ajnava commented Feb 7, 2019

Description

Checklist

@vladimir-shcherbakov
Copy link
Contributor

@v-Ajnava ci-build has failed - please take a look.

@v-Ajnava
Copy link
Author

v-Ajnava commented Feb 8, 2019

@vladimir-shcherbakov I have updated EventHub nuget version in Iot Hub Tests, now the build is green.

maddieclayton
maddieclayton suggested changes Feb 9, 2019
View reviewed changes
Copy link
Contributor

@maddieclayton maddieclayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small changes and then this look good to go.

src/EventHub/EventHub.Test/EventHub.Test.csproj Outdated
<PackageReference Include="Microsoft.Azure.Management.EventHub" Version="2.4.0" />
</ItemGroup>

<ItemGroup>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this - it is done automatically. The only change in this file should be the version of the management client.

src/EventHub/EventHub/ChangeLog.md Outdated
@@ -18,6 +18,7 @@
- Additional information about change #1
-->
## Upcoming Release
* added new boolean property SkipEmptyArchives to Skip Empty Archives in CaptureDescription class of Eventhub
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please capitalize "Added" for consistency in our changelogs.

@v-Ajnava v-Ajnava removed the request for review from rrama-Microsoft February 11, 2019 21:12
@v-Ajnava
Copy link
Author

I have unassigned @rrama-Microsoft, as he is on leave.

@maddieclayton maddieclayton merged commit 1229c76 into Azure:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maddieclayton maddieclayton maddieclayton approved these changes

Assignees
No one assigned
Labels
Waiting for CI :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@v-Ajnava @vladimir-shcherbakov @maddieclayton @azuresdkci @rrama-Microsoft