Skip to content

Add support for Private DNS VirtualNetwork links #8623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 2, 2019
Merged

Add support for Private DNS VirtualNetwork links #8623

merged 5 commits into from
Mar 2, 2019

Conversation

pranavpnair
Copy link

@pranavpnair pranavpnair commented Feb 26, 2019 •
edited
Loading

Description

Added powershell cmdlet support for create/update/delete Private DNS VirtualNetwork links in azure. Detailed design doc can be found here: Azure/azure-powershell-cmdlet-review-pr#233

Checklist

@pranavpnair pranavpnair requested a review from muwaqar February 26, 2019 09:21
muwaqar
muwaqar previously requested changes Feb 28, 2019
View reviewed changes
maddieclayton
maddieclayton suggested changes Feb 28, 2019
View reviewed changes
maddieclayton
maddieclayton suggested changes Mar 1, 2019
View reviewed changes
@pranavpradeepnair
Addressing comments
9a4299c 
Addressing comments

Addressing comments

Addressing comments

Addressing comments
@maddieclayton maddieclayton merged commit d5c8d0e into Azure:master Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maddieclayton maddieclayton maddieclayton approved these changes

@muwaqar muwaqar muwaqar left review comments

Assignees

@pranavpnair pranavpnair

Labels
Cmdlet Review Complete needs-revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pranavpnair @muwaqar @maddieclayton @azuresdkci @pranavpradeepnair