Upgrade network sdk and rerun privatedns tests #8734
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-Recorded test files after Network SDK upgrade for PrivateDns module.
Email from Anton:
Hi, @pranav Nair,
We’re updating Network SDK in Azure PowerShell which uses a newer API version. Because of that we also have to update PrivateDns’ test recordings but those tests are failing for us with “Long running operation failed with status 'Failed'” (you can find the list in attachments).
Could you please set version of “Microsoft.Azure.Management.Network” in PrivateDns.Test.csproj to “19.9.0-preview” and re-record PrivateDns’ tests (you can either open a PR in master or just send updated JSONs to me)? That would help us get unblocked.
Best regards,
Anton Evseev
Checklist
CONTRIBUTING.md
platyPS
module