Skip to content

Upgrade network sdk and rerun privatedns tests #8734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2019

Conversation

pranavpnair
Copy link

@pranavpnair pranavpnair commented Mar 9, 2019

Description

Re-Recorded test files after Network SDK upgrade for PrivateDns module.

Email from Anton:
Hi, @pranav Nair,

We’re updating Network SDK in Azure PowerShell which uses a newer API version. Because of that we also have to update PrivateDns’ test recordings but those tests are failing for us with “Long running operation failed with status 'Failed'” (you can find the list in attachments).
Could you please set version of “Microsoft.Azure.Management.Network” in PrivateDns.Test.csproj to “19.9.0-preview” and re-record PrivateDns’ tests (you can either open a PR in master or just send updated JSONs to me)? That would help us get unblocked.

Best regards,
Anton Evseev

Checklist

@maddieclayton maddieclayton merged commit 10e331a into Azure:master Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants