Skip to content

Preview Az.Peering #8830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
May 2, 2019
Merged

Preview Az.Peering #8830

merged 44 commits into from
May 2, 2019

Conversation

rileymckenna
Copy link
Contributor

@rileymckenna rileymckenna commented Mar 22, 2019

Description

Initial Build of new module Az.Peering Issue.

Checklist

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@vladimir-shcherbakov
Copy link
Contributor

@rileymckenna ci-build is failing.

@vladimir-shcherbakov
Copy link
Contributor

@azuresdkci Add to whitelist

@rileymckenna
Copy link
Contributor Author

@vladimir-shcherbakov Could not copy the file "obj\Debug\Microsoft.Azure.PowerShell.Cmdlets.Peering.dll" because it was not found. [c:\workspace\powershell\src\Peering\Peering\Peering.csproj] i keep running into this build error. Any ideas?

@rileymckenna
Copy link
Contributor Author

build fails on help generator

@vladimir-shcherbakov
Copy link
Contributor

image

online version shouldn't be empty.

@rileymckenna
Copy link
Contributor Author

@vladimir-shcherbakov I am failing on Travis NONCORE tests? why?

@rileymckenna
Copy link
Contributor Author

@vladimir-shcherbakov errors i cant figure out what this is?

@cormacpayne
Copy link
Member

@rileymckenna Hey Riley, would you mind pulling the latest from the master branch in the Azure fork and then doing a rebase to clean up the number of commits that are in this PR?

@cormacpayne
Copy link
Member

@rileymckenna also, for the error you called out above, you will need to add an Az.Peering folder to tools/StaticAnalysis/Exceptions, and in this folder, you can just copy-paste that MissingAssemblies.csv file in there.

@rileymckenna
Copy link
Contributor Author

@cormacpayne Hey i rebased and squashed to a single commit. Hopefully it will build this time!

@rileymckenna
Copy link
Contributor Author

@cormacpayne build failure with artifact upload.

@rileymckenna rileymckenna requested review from cormacpayne and niander and removed request for maddieclayton April 23, 2019 00:15
@cormacpayne
Copy link
Member

Copy link
Member

@cormacpayne cormacpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rileymckenna a few minor comments -- we can sync up online about whether we want to take these changes now or in a new iteration

@cormacpayne
Copy link
Member

cormacpayne
cormacpayne previously approved these changes Apr 29, 2019
@cormacpayne
Copy link
Member

This module has been published -- will wait for the current release branch to be merged back into master before merging this PR.

@cormacpayne cormacpayne merged commit 0d6ecc0 into Azure:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants