-
Notifications
You must be signed in to change notification settings - Fork 4k
ADO changes to follow guidelines #8966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d832046
Removed build folder. Moving yaml files to follow guidelines.
MiYanni f1d1149
Moved steps files into util.
MiYanni 3041699
Added ADO v2 pipeline. Updated build.proj to use consistent path vari…
MiYanni 28c7b3b
Attempting to fix variable replacement.
MiYanni 109fba6
Fix for matrix defined variables.
MiYanni 413eba0
Fixed variable names to follow standards. Removed necessity to define…
MiYanni b920f4f
Resolving template variables needs verbose syntax.
MiYanni 61bcd83
More tests with variable passing.
MiYanni a88ff73
Changing matrix variable name.
MiYanni 33fb710
Removed install-pwsh-steps.yml since it is no longer needed.
MiYanni 4921338
Calling powershell using name instead of exe location.
MiYanni eb0e35b
Made TestNet472 actually build tests so it can run tests.
MiYanni 40adb82
Updated variable names to avoid clashing with built-in variable names.
MiYanni 391e2b3
Added _matrix postfix to not clash with built-in variable names when …
MiYanni b9754eb
Matrix name definitions do not use variable resolution properly. So, …
MiYanni 12e8634
Merge branch 'master' into ado-v2
MiYanni e23f335
Space fix to make new commit to kick CI.
MiYanni 5dac1a0
Text change to trigger CI.
MiYanni 0059848
Changed pipeline names to match scenario intent instead of test frame…
MiYanni a2a5e56
Updated matrix variable casing.
MiYanni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| variables: | ||
| WindowsName: windows | ||
| WindowsImage: VS2017-Win2016 | ||
| LinuxName: linux | ||
| LinuxImage: Ubuntu-16.04 | ||
| MacOSName: macOS | ||
| MacOSImage: macOS-10.13 | ||
| TestFramework: netcoreapp2.1 | ||
| TestTarget: Test | ||
| Configuration: Debug | ||
|
|
||
| jobs: | ||
| - job: Build | ||
| displayName: Build | ||
| condition: succeeded() | ||
| strategy: | ||
| matrix: | ||
| windows: | ||
| OSName: ${{ variables.WindowsName }} | ||
| ImageName: ${{ variables.WindowsImage }} | ||
| linux: | ||
| OSName: ${{ variables.LinuxName }} | ||
| ImageName: ${{ variables.LinuxImage }} | ||
| macOS: | ||
| OSName: ${{ variables.MacOSName }} | ||
| ImageName: ${{ variables.MacOSImage }} | ||
| pool: | ||
| vmImage: $(ImageName) | ||
|
|
||
| steps: | ||
| - template: util/build-steps.yml | ||
| parameters: | ||
| osName: $(OSName) | ||
| testFramework: ${{ variables.TestFramework }} | ||
| configuration: ${{ variables.Configuration }} | ||
|
|
||
| - job: Analyze | ||
| displayName: Analyze | ||
| dependsOn: Build | ||
| condition: succeeded() | ||
| strategy: | ||
| matrix: | ||
| windows: | ||
| OSName: ${{ variables.WindowsName }} | ||
| ImageName: ${{ variables.WindowsImage }} | ||
| linux: | ||
| OSName: ${{ variables.LinuxName }} | ||
| ImageName: ${{ variables.LinuxImage }} | ||
| macOS: | ||
| OSName: ${{ variables.MacOSName }} | ||
| ImageName: ${{ variables.MacOSImage }} | ||
| pool: | ||
| vmImage: $(ImageName) | ||
|
|
||
| steps: | ||
| - template: util/analyze-steps.yml | ||
| parameters: | ||
| osName: $(OSName) | ||
| configuration: ${{ variables.Configuration }} | ||
|
|
||
| - job: Test | ||
| displayName: Test | ||
| dependsOn: Build | ||
| condition: succeeded() | ||
| timeoutInMinutes: 120 | ||
| strategy: | ||
| matrix: | ||
| windows: | ||
| OSName: ${{ variables.WindowsName }} | ||
| ImageName: ${{ variables.WindowsImage }} | ||
| linux: | ||
| OSName: ${{ variables.LinuxName }} | ||
| ImageName: ${{ variables.LinuxImage }} | ||
| macOS: | ||
| OSName: ${{ variables.MacOSName }} | ||
| ImageName: ${{ variables.MacOSImage }} | ||
| pool: | ||
| vmImage: $(ImageName) | ||
|
|
||
| steps: | ||
| - template: util/test-steps.yml | ||
| parameters: | ||
| osName: $(OSName) | ||
| testFramework: ${{ variables.TestFramework }} | ||
| testTarget: ${{ variables.TestTarget }} | ||
| configuration: ${{ variables.Configuration }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| parameters: | ||
| osName: '' | ||
| configuration: '' | ||
|
|
||
| steps: | ||
| - template: download-build-steps.yml | ||
| parameters: | ||
| osName: ${{ parameters.osName }} | ||
|
|
||
| - pwsh: 'Install-Module platyPS -Force -Confirm:$false -Scope CurrentUser' | ||
| displayName: 'Install platyPS' | ||
|
|
||
| - task: DotNetCoreCLI@2 | ||
| displayName: 'Generate Help' | ||
| inputs: | ||
| command: custom | ||
| custom: msbuild | ||
| arguments: 'build.proj /t:GenerateHelp /p:Configuration=${{ parameters.configuration }}' | ||
|
|
||
| - task: DotNetCoreCLI@2 | ||
| displayName: 'Static Analysis' | ||
| inputs: | ||
| command: custom | ||
| custom: msbuild | ||
| arguments: 'build.proj /t:StaticAnalysis /p:Configuration=${{ parameters.configuration }}' | ||
|
|
||
| - template: publish-artifacts-steps.yml | ||
| parameters: | ||
| artifactName: analyze-${{ parameters.osName }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| parameters: | ||
| osName: '' | ||
| testFramework: '' | ||
| configuration: '' | ||
|
|
||
| steps: | ||
| - task: DotNetCoreCLI@2 | ||
| displayName: Build | ||
| inputs: | ||
| command: custom | ||
| custom: msbuild | ||
| arguments: 'build.proj /t:Build /p:Configuration=${{ parameters.configuration }};TestFramework=${{ parameters.testFramework }}' | ||
|
|
||
| - template: publish-artifacts-steps.yml | ||
| parameters: | ||
| artifactName: build-${{ parameters.osName }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| parameters: | ||
| osName: '' | ||
|
|
||
| steps: | ||
| - task: DownloadPipelineArtifact@0 | ||
| displayName: 'Download build-${{ parameters.osName }}' | ||
| inputs: | ||
| artifactName: build-${{ parameters.osName }} | ||
| targetPath: artifacts | ||
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| parameters: | ||
| osName: '' | ||
| testFramework: '' | ||
| testTarget: '' | ||
| configuration: '' | ||
|
|
||
| steps: | ||
| - template: download-build-steps.yml | ||
| parameters: | ||
| osName: ${{ parameters.osName }} | ||
|
|
||
| - task: DotNetCoreCLI@2 | ||
| displayName: Test | ||
| inputs: | ||
| command: custom | ||
| custom: msbuild | ||
| arguments: 'build.proj /t:${{ parameters.testTarget }} /p:Configuration=${{ parameters.configuration }};TestFramework=${{ parameters.testFramework }}' | ||
|
|
||
| - template: publish-artifacts-steps.yml | ||
| parameters: | ||
| artifactName: test-${{ parameters.osName }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| variables: | ||
| WindowsName: windows | ||
| WindowsImage: VS2017-Win2016 | ||
| TestFramework: net472 | ||
| TestTarget: TestNet472 | ||
| Configuration: Debug | ||
|
|
||
| jobs: | ||
| - job: Build | ||
| displayName: Build | ||
| condition: succeeded() | ||
| pool: | ||
| vmImage: ${{ variables.WindowsImage }} | ||
|
|
||
| steps: | ||
| - template: util/build-steps.yml | ||
| parameters: | ||
| osName: ${{ variables.WindowsName }} | ||
| testFramework: ${{ variables.TestFramework }} | ||
| configuration: ${{ variables.Configuration }} | ||
|
|
||
| - job: Test | ||
| displayName: Test | ||
| dependsOn: Build | ||
| condition: succeeded() | ||
| timeoutInMinutes: 120 | ||
| pool: | ||
| vmImage: ${{ variables.WindowsImage }} | ||
|
|
||
| steps: | ||
| - template: util/test-steps.yml | ||
| parameters: | ||
| osName: ${{ variables.WindowsName }} | ||
| testFramework: ${{ variables.TestFramework }} | ||
| testTarget: ${{ variables.TestTarget }} | ||
| configuration: ${{ variables.Configuration }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a number of these templates can be folded into the one yaml file to avoid some levels of complexity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these are reused between different jobs in different pipelines, it makes sense to have a separate template. The primary issue is that you cannot template a job matrix. Meaning, I can't make a job template where a strategy is conditionally defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that is one of the limitations of the templates. However I don't think that would be necessary if you had one matrix strategy for both and just control the framework as one of the matrix variables.