Updated SDK (localfeed) and recordings #8979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EvgenyAgafonchikov Please let me know when you are ready for one of us to take a look at this. |
EvgenyAgafonchikov
changed the title
|
@MiYanni can you please escalate this PR merging? it contains recordings really needed for contribution process |
|
@maddieclayton, please review. Currently I have to skip one test as we have no related feature activated however I hope we could activate and re-record it soon |
MiYanni
suggested changes
Apr 10, 2019
| @@ -49,7 +49,6 @@ public class NewAzureFirewallApplicationRuleCollectionCommand : NetworkBaseCmdle | |||
| [ValidateSet( | |||
| MNM.AzureFirewallRCActionType.Allow, | |||
| MNM.AzureFirewallRCActionType.Deny, | |||
| MNM.AzureFirewallRCActionType.Alert, | |||
There was a problem hiding this comment.
This is a breaking change. Alert was added in Network 1.6.0, and cannot be removed outside of a breaking change release. Please revert.
| @@ -50,7 +50,6 @@ public class NewAzureFirewallNetworkRuleCollectionCommand : NetworkBaseCmdlet | |||
| [ValidateSet( | |||
| MNM.AzureFirewallRCActionType.Allow, | |||
| MNM.AzureFirewallRCActionType.Deny, | |||
| MNM.AzureFirewallRCActionType.Alert, | |||
There was a problem hiding this comment.
This is a breaking change. Alert was added in Network 1.6.0, and cannot be removed outside of a breaking change release. Please revert.
There was a problem hiding this comment.
@fanymanea please review comment from PS team. please discuss you change and revert if it's needed
| @@ -441,3 +441,5 @@ | |||
| "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureApplicationGatewayUrlPathMapConfigCommand","New-AzApplicationGatewayUrlPathMapConfig","0","1050","The parameter set 'SetByResource' for cmdlet 'New-AzApplicationGatewayUrlPathMapConfig' has been removed.","Add parameter set 'SetByResource' back to cmdlet 'New-AzApplicationGatewayUrlPathMapConfig'." | |||
| "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.SetAzureApplicationGatewayUrlPathMapConfigCommand","Set-AzApplicationGatewayUrlPathMapConfig","0","1050","The parameter set 'SetByResourceId' for cmdlet 'Set-AzApplicationGatewayUrlPathMapConfig' has been removed.","Add parameter set 'SetByResourceId' back to cmdlet 'Set-AzApplicationGatewayUrlPathMapConfig'." | |||
| "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.SetAzureApplicationGatewayUrlPathMapConfigCommand","Set-AzApplicationGatewayUrlPathMapConfig","0","1050","The parameter set 'SetByResource' for cmdlet 'Set-AzApplicationGatewayUrlPathMapConfig' has been removed.","Add parameter set 'SetByResource' back to cmdlet 'Set-AzApplicationGatewayUrlPathMapConfig'." | |||
| "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureFirewallApplicationRuleCollectionCommand","New-AzFirewallApplicationRuleCollection","0","2040","The validation set for parameter 'ActionType' for cmdlet 'New-AzFirewallApplicationRuleCollection' no longer contains the value 'Alert'.","Add 'Alert' back to the validation set for 'ActionType'." | |||
| "Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureFirewallNetworkRuleCollectionCommand","New-AzFirewallNetworkRuleCollection","0","2040","The validation set for parameter 'ActionType' for cmdlet 'New-AzFirewallNetworkRuleCollection' no longer contains the value 'Alert'.","Add 'Alert' back to the validation set for 'ActionType'." | |||
There was a problem hiding this comment.
After Alert is readded, please revert these suppressions.
MiYanni
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdplatyPSmodule