-
Notifications
You must be signed in to change notification settings - Fork 4k
Add SecurityTools (CredScan, BinSkim, PoliCheck) to PR builds in ADO #9035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
4894222
Added release build job.
MiYanni 2a94ba7
Initial attempt at release process.
MiYanni e910017
Update release pipeline to (hopefully) work.
MiYanni 7a862e7
Merge branch 'master' into ado-v2-release
MiYanni 9142477
Changed condition for certain processes to use Release configuration …
MiYanni f8d1372
Space fix
MiYanni 246c04f
Removed release yaml since it is not used to do releases.
MiYanni c7531d2
Merge branch 'master' into ado-v2-release
MiYanni 8cd180d
Added package config for getting security tools.
MiYanni ab54daf
Merge branch 'master' into ado-v2-release
MiYanni 3112aa7
Merge branch 'ado-v2-release' into securitytools-changes
MiYanni 1b12d25
Updated packages config for SecurityTools. Added nuget config for Sec…
MiYanni 3d14471
Apparently, the names need to be in a specific format.
MiYanni 5a6158f
Added PoliCheck list of file extensions.
MiYanni 7db9822
Added CredScan suppressions for non-test files.
MiYanni eba02f3
Trying back slashes for suppressions.
MiYanni ef9d894
Fixed suppressions files to have correct paths and removal of duplica…
MiYanni f6bc4b1
Added verified suppressions (or adjusted code) for CredScan.
MiYanni e188450
Added missing suppression.
MiYanni a67dc44
Added scripts for running security tools. Added security tools tasks …
MiYanni b61428f
Removed travis yml.
MiYanni a991036
Change to retrigger CI.
MiYanni c2857c1
Cannot download the SecurityTools from the nuget feed. Attempting to …
MiYanni 89405cd
Changed package info to correct GUIDs.
MiYanni cbe183a
Changed feed for accessing tools.
MiYanni 9fa3aad
Removed CredScan and PoliCheck scripts and tasks from yml.
MiYanni e728ea6
Test file to retrigger CI
MiYanni 91711cc
Changed folder from SecurityToolsScripts to SecurityTools.
MiYanni adc4506
Removed legacy security tools scripts. Moved security tools assets to…
MiYanni 7a97c79
Removed unused suppressions file. Additional suppression for BinSkim.
MiYanni 3f22cf5
Updated BinSkim script path.
MiYanni 299d85d
Merge branch 'master' into securitytools-changes
MiYanni 54dfed1
Added suppression for generated test resource group.
MiYanni b2bf167
Removed temp file from CI testing.
MiYanni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These variables were unused in this class and were flagged by CredScan. Made more sense to remove unused creds than to suppress them.