Skip to content

[Compute] PPG cmdlets and others. #9079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 29, 2019
Merged

[Compute] PPG cmdlets and others. #9079

merged 6 commits into from
Apr 29, 2019

Conversation

hyonholee
Copy link
Contributor

@hyonholee hyonholee commented Apr 25, 2019 •
edited
Loading

Description

  • Proximity Placement Group cmdlets:

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/245

  • StorageAccountType for GalleryImageVersion

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/267

  • Skip Shutdown for Stop VM/VMSS

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/281

  • Breaking changes

Checklist

@hyonholee hyonholee force-pushed the april2 branch 3 times, most recently from 5e3a5c2 to 188ed33 Compare April 25, 2019 06:34
@markcowl
Copy link
Member

@hyonholee What are you waiting for to make this PR OK to merge?

@hyonholee
Copy link
Contributor Author

@markcowl I need to update SDK reference, because the current SDK has a bug. I will update PR today.

@hyonholee
Merge branch 'master' of https://github.com/Azure/azure-powershell in…
318ecdf 
…to april2

# Conflicts:
#	src/RecoveryServices/RecoveryServices.Backup.Test/RecoveryServices.Backup.Test.csproj
@hyonholee hyonholee changed the title [Compute] [Do not merge yet] PPG cmdlets and others. [Compute] PPG cmdlets and others. Apr 26, 2019
@hyonholee
Copy link
Contributor Author

One network test failed

Commands.Network.Test.ScenarioTests.VirtualNetworkGatewayTests.VirtualNetworkGatewayIkeV2Test [FAIL]

@markcowl
Copy link
Member

@hyonholee @cormacpayne My guess is that this branch doesn't have all of the network updates - updated the branch and we can see if that fixes the issue.

@cormacpayne cormacpayne changed the base branch from master to release-2019-05-06 April 26, 2019 19:41
@hyonholee hyonholee requested a review from cormacpayne April 26, 2019 21:46
markcowl
markcowl requested changes Apr 29, 2019
View reviewed changes
Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On hard coded test locations- If you don't have time to fix these for the release, you may file an issue and fix before your next update (in the next sprint)

@hyonholee hyonholee requested a review from markcowl April 29, 2019 08:50
@markcowl markcowl merged commit 8bb7287 into Azure:release-2019-05-06 Apr 29, 2019
@hyonholee hyonholee deleted the april2 branch June 19, 2019 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markcowl markcowl markcowl approved these changes

@cormacpayne cormacpayne Awaiting requested review from cormacpayne

Assignees

@hyonholee hyonholee

Labels
Sprint Candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyonholee @markcowl @azuresdkci