Rename WAF cmdlets from *-AzFrontDoor* to *-AzFrontDoorWaf* #9100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digavino
previously approved these changes
Apr 29, 2019
markcowl
requested changes
Apr 29, 2019
| "Set-AzFrontDoorFireWallPolicy": "Set-AzureRmFrontDoorFireWallPolicy", | ||
| "Remove-AzFrontDoorFireWallPolicy": "Remove-AzureRmFrontDoorFireWallPolicy", | ||
| "New-AzFrontDoorRuleGroupOverrideObject": "New-AzureRmFrontDoorRuleGroupOverrideObject", | ||
| "New-AzFrontDoorWafMatchConditionObject": "New-AzureRmFrontDoorWafMatchConditionObject", |
There was a problem hiding this comment.
You should change only the Az name of the cmdlet here, and not the AzureRm cmdlet name
| @@ -18,6 +18,9 @@ | |||
| - Additional information about change #1 | |||
| --> | |||
| ## Upcoming Release | |||
| ## Version 0.7.5 | |||
| * Rename WAF cmdlets to include 'Waf' | |||
|
|
|||
There was a problem hiding this comment.
Please list the cmdlet name changes here
markcowl
approved these changes
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is rename of below cmdlets to include feature name WAF. The name is changed from
Get-AzFrontDoorFireWallPolicy --> Get-AzFrontDoorWafPolicy
New-AzFrontDoorCustomRuleObject --> New-AzFrontDoorWafCustomRuleObject
New-AzFrontDoorFireWallPolicy --> New-AzFrontDoorWafPolicy
New-AzFrontDoorManagedRuleObject --> New-AzFrontDoorWafManagedRuleObject
New-AzFrontDoorManagedRuleOverrideObject --> New-AzFrontDoorWafManagedRuleOverrideObject
New-AzFrontDoorMatchConditionObject --> New-AzFrontDoorWafMatchConditionObject
New-AzFrontDoorRuleGroupOverrideObject --> New-AzFrontDoorWafRuleGroupOverrideObject
Remove-AzFrontDoorFireWallPolicy --> Remove-AzFrontDoorWafPolicy
Update-AzFrontDoorFireWallPolicy --> Update-AzFrontDoorWafPolicy
Approved issue - https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/284
Checklist
CONTRIBUTING.mdplatyPSmodule