Support for Serverless specific parameters for CRUD #9105
Conversation
|
Can one of the admins verify this patch? |
| .SYNOPSIS | ||
| Tests updating a vcore database | ||
| #> | ||
| function Test-UpdateServerlessDatabase() |
|
Your PR will fail with STatic Analysis Issues, you will need to add suppressions for these: https://dev.azure.com/azure-sdk/29ec6040-b234-4e31-b139-33dc4287b756/_apis/build/builds/23503/artifacts?artifactName=analyze-windows&fileId=D1580ED802489C071199F16D29F3F84A7E30EB7C465B0CE5422376583830D7DB01&fileName=SignatureIssues.csv&api-version=5.0-preview.3 |
| { | ||
| if (string.IsNullOrWhiteSpace(tier)) | ||
| { | ||
| return null; | ||
| } | ||
|
|
||
| return SqlSkuUtils.GetVcoreSkuPrefix(tier) ?? tier; | ||
| return (SqlSkuUtils.GetVcoreSkuPrefix(tier) ?? tier) + (isServerless ? "_S" : ""); |
There was a problem hiding this comment.
There is already a unit test for this method, would be nice if you added isServerless coverage to that test.
| @@ -213,6 +223,8 @@ public AzureSqlDatabaseModel(string resourceGroup, string serverName, Management | |||
| ReadScale = readScale; | |||
|
|
|||
| ZoneRedundant = false; | |||
| AutoPauseDelayInMinutes = null; | |||
| MinimumCapacity = null; | |||
There was a problem hiding this comment.
You should be setting these. Otherwise they will always be null in response!
There was a problem hiding this comment.
Sorry, I'm wrong. This is converting from legacy model
|
@azuresdkci add to whitelist |
|
Marked as do not merge until the release branch is merged back |
Description
Adding MinCapacity and AutoPauseDelay and ComputeModel optional parameters for Serverless databases CRUD
Checklist
CONTRIBUTING.mdplatyPSmodule