Deprecating Get-AzSqlDatabaseSecureConnectionPolicy cmdlet #9146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaakoviyun
reviewed
May 7, 2019
| @@ -18,6 +18,7 @@ | |||
| - Additional information about change #1 | |||
| --> | |||
| ## Upcoming Release | |||
| * Deprecating Get-AzSqlDatabaseSecureConnectionPolicy cmdlet | |||
There was a problem hiding this comment.
there is no set cmdlet
| @@ -22,6 +22,7 @@ namespace Microsoft.Azure.Commands.Sql.SecureConnection.Cmdlet | |||
| /// Returns the secure connection policy of a specific database. | |||
| /// </summary> | |||
| [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "SqlDatabaseSecureConnectionPolicy", SupportsShouldProcess = true), OutputType(typeof(DatabaseSecureConnectionPolicyModel))] | |||
| [Obsolete("Note that secure connection is deprecated and this command will be removed in a future release. Please use the SQL database blade in the Azure portal to view the connection strings", false)] | |||
There was a problem hiding this comment.
close with PM.
I will point PS customers to the portal
There was a problem hiding this comment.
Do not use Obsolete. Use our breaking change attributes: https://github.com/Azure/azure-powershell/blob/master/documentation/breaking-changes/breaking-changes-attribute-help.md
| @@ -117,7 +117,8 @@ Gets the geo-replication links between an Azure SQL Database and a resource grou | |||
| Retrieves the distinct restore points from which a SQL Data Warehouse can be restored. | |||
|
|
|||
| ### [Get-AzSqlDatabaseSecureConnectionPolicy](Get-AzSqlDatabaseSecureConnectionPolicy.md) | |||
| Gets the secure connection policy for a database. | |||
| Gets the secure connection policy for a database. | |||
There was a problem hiding this comment.
do we have cmdlet for server connection policy too?
MiYanni
suggested changes
May 11, 2019
| @@ -22,6 +22,7 @@ namespace Microsoft.Azure.Commands.Sql.SecureConnection.Cmdlet | |||
| /// Returns the secure connection policy of a specific database. | |||
| /// </summary> | |||
| [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "SqlDatabaseSecureConnectionPolicy", SupportsShouldProcess = true), OutputType(typeof(DatabaseSecureConnectionPolicyModel))] | |||
| [Obsolete("Note that secure connection is deprecated and this command will be removed in a future release. Please use the SQL database blade in the Azure portal to view the connection strings", false)] | |||
There was a problem hiding this comment.
Do not use Obsolete. Use our breaking change attributes: https://github.com/Azure/azure-powershell/blob/master/documentation/breaking-changes/breaking-changes-attribute-help.md
merge master changes from origin
MiYanni
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdplatyPSmodule