Added ability to set 'Description' field when calling New-AzADGroup (Issue #9004) #9183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiYanni
previously requested changes
May 14, 2019
src/Resources/Resources/ActiveDirectory/Models/ActiveDirectoryClientExtensions.cs
Outdated
Show resolved
Hide resolved
src/Resources/Resources/ActiveDirectory/Models/ActiveDirectoryClientExtensions.cs
Outdated
Show resolved
Hide resolved
src/Resources/Resources/ActiveDirectory/Models/ActiveDirectoryClientExtensions.cs
Outdated
Show resolved
Hide resolved
src/Resources/Resources/ActiveDirectory/Models/ActiveDirectoryClientExtensions.cs
Outdated
Show resolved
Hide resolved
…ClientExtensions.cs Co-Authored-By: Michael Yanni <[email protected]>
…ClientExtensions.cs Co-Authored-By: Michael Yanni <[email protected]>
…ClientExtensions.cs Co-Authored-By: Michael Yanni <[email protected]>
…ClientExtensions.cs Co-Authored-By: Michael Yanni <[email protected]>
|
Thanks @MiYanni for those one-liners, just learnt about ?.ToString() |
|
@darshanhs90 Can you take a look at this PR? |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
cormacpayne
previously approved these changes
May 21, 2019
There was a problem hiding this comment.
@lwajswaj I made a few minor changes -- this looks great otherwise. Thanks for the contribution 😁
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
cormacpayne
approved these changes
May 24, 2019
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
cormacpayne
approved these changes
May 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds 'Description' parameter to New-AzAdGroup cmdlet (Issue #9004) as well as adds it as output when calling Get-AzAdGroup. Also, fixed value displayed as MailNickName.
Checklist
CONTRIBUTING.mdplatyPSmodule