Update Start-AzAutomationDscNodeConfigurationDeployment to create a new JobId on each execution

[lwajswaj]

Description

This PR fixes initially error shown in issue #8921; the error was related to a wrong Guid generation for the job. Last error is given because, it seems, runbook "Deploy-NodeConfigurationToAutomationDscNodesV1" has some underlying error.

The cmdlet now works but the runbook is erroring out; somebody with access to the runbook should continue debugging. This is what my tests show:

PS C:\Users\Leandro> Start-AzAutomationDscNodeConfigurationDeployment -NodeConfigurationName "LinuxConfig.localhost" -NodeName LinuxVM01 -ResourceGroupName TestAutomation -AutomationAccountName TestAutomation -Force

ResourceGroupName     : TestAutomation
AutomationAccountName : TestAutomation
JobId                 : c63d82ba-c449-4cfa-a6f0-ec9f00697a00
Job                   : Microsoft.Azure.Commands.Automation.Model.Job
JobStatus             : New
NodeStatus            :
NodeConfigurationName : LinuxConfig.localhost
JobSchedule           :
JobScheduleId         : 00000000-0000-0000-0000-000000000000


PS C:\Users\Leandro> $Job = Get-AzAutomationDscNodeConfigurationDeployment -JobId c63d82ba-c449-4cfa-a6f0-ec9f00697a00 -ResourceGroupName TestAutomation -AutomationAccountName TestAutomation
PS C:\Users\Leandro> $Job

ResourceGroupName     : TestAutomation
AutomationAccountName : TestAutomation
JobId                 : c63d82ba-c449-4cfa-a6f0-ec9f00697a00
Job                   : Microsoft.Azure.Commands.Automation.Model.Job
JobStatus             : Failed
NodeStatus            : {System.Collections.Generic.Dictionary`2[System.String,System.String]}
NodeConfigurationName : LinuxConfig.localhost
JobSchedule           :
JobScheduleId         : 00000000-0000-0000-0000-000000000000


PS C:\Users\Leandro> $Job.Job

ResourceGroupName      : TestAutomation
AutomationAccountName  : TestAutomation
JobId                  : c63d82ba-c449-4cfa-a6f0-ec9f00697a00
CreationTime           : 11/05/2019 22:17:25 -03:00
Status                 : Failed
StatusDetails          : None
StartTime              : 11/05/2019 22:17:44 -03:00
EndTime                : 11/05/2019 22:17:44 -03:00
Exception              : Could not finish the NodeConfiguration Deployment. Following exception occurred : Cannot bind parameter 'Id'. Cannot convert value "/subscript
                         ions/<subscriptionId>/resourceGroups/TestAutomation/providers/Microsoft.Automation/automationAccounts/TestAutomation/nodes
                         /a1e2e575-e547-41af-8c70-360f92eb12ba" to type "System.Guid". Error: "Guid should contain 32 digits with 4 dashes
                         (xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx).".Exception.Message (Could not finish the NodeConfiguration Deployment. Following exception occurred :
                         Cannot bind parameter 'Id'. Cannot convert value "/subscriptions/<subscriptionId>/resourceGroups/TestAutomation/providers/
                         Microsoft.Automation/automationAccounts/TestAutomation/nodes/a1e2e575-e547-41af-8c70-360f92eb12ba" to type "System.Guid". Error: "Guid should
                         contain 32 digits with 4 dashes (xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx).".Exception.Message)
LastModifiedTime       : 11/05/2019 22:17:44 -03:00
LastStatusModifiedTime : 11/05/2019 22:17:44 -03:00
JobParameters          : {NodeConfigurationName, AutomationAccountName, ListOfNodeNames, ResourceGroupName…}
RunbookName            : Deploy-NodeConfigurationToAutomationDscNodesV1
HybridWorker           :
StartedBy              : {scrubbed}


PS C:\Users\Leandro>

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate change log has been updated
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • the changes have gone through a cmdlet design review (Microsoft internal partners only)
  • the cmdlet markdown files were generated using the platyPS module

[MiYanni]

@avkaur Please review this PR when you have time available.

[MiYanni]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[lwajswaj]

Any update on this PR?

[cormacpayne]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).