Make New-AzSqlInstance -StorageSizeInGB parameter optional #9203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrajkogit
previously approved these changes
May 15, 2019
MiYanni
suggested changes
May 15, 2019
src/Sql/Sql/ManagedInstance/Cmdlet/NewAzureSqlManagedInstance.cs
Outdated
Show resolved
Hide resolved
tools/StaticAnalysis/Exceptions/Az.Sql/BreakingChangeIssues.csv
Outdated
Show resolved
Hide resolved
The service doesn't require these parameters and will automatically choose default values if not specified.
jaredmoo
force-pushed
the
instanceSizeOptional
branch
from
3502826 to
b63d73f
Compare
|
Rerecord tests: done. I didn't add specific tests, just changed common code path to avoid setting these params, which gives us verification that provisioning succeeds without these params. |
- Getting subnet fails when there is not exactly one subnet - Need to use region that is available for provisioning. Only making this change for tests that I am rerecording.
jaredmoo
force-pushed
the
instanceSizeOptional
branch
from
b63d73f to
4349726
Compare
MiYanni
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The service doesn't require this parameter and will automatically choose a default value if not specified.
Checklist
CONTRIBUTING.mdplatyPSmodule