GuestConfig PS Cmdlets: Fix Inconsistencies in compliance status #9344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markcowl
requested changes
Jun 4, 2019
...stConfiguration/GuestConfiguration.Test/ScenarioTests/GetVmGuestPolicyStatusHistoryTests.ps1
Show resolved
Hide resolved
src/GuestConfiguration/GuestConfiguration.Test/ScenarioTests/GetVmGuestPolicyStatusTests.ps1
Show resolved
Hide resolved
src/GuestConfiguration/GuestConfiguration.Test/GuestConfiguration.Test.csproj
Outdated
Show resolved
Hide resolved
src/GuestConfiguration/GuestConfiguration/Common/GuestConfigurationCmdletBase.cs
Show resolved
Hide resolved
src/GuestConfiguration/GuestConfiguration/GuestConfiguration.csproj
Outdated
Show resolved
Hide resolved
|
@aashish1987 Please update this PR as specified. Code complete for the current release is today |
|
Waiting for this PR to be merged before continuing: #9460 |
cormacpayne
previously requested changes
Jun 24, 2019
There was a problem hiding this comment.
@aashish1987 a couple of comments otherwise LGTM outside of the comments made by @markcowl about removing hard-coded values from the tests
src/GuestConfiguration/GuestConfiguration.Test/GuestConfiguration.Test.csproj
Outdated
Show resolved
Hide resolved
src/GuestConfiguration/GuestConfiguration/GuestConfiguration.csproj
Outdated
Show resolved
Hide resolved
|
@aashish1987 ping on the comments above |
markcowl
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdplatyPSmodule