-
Notifications
You must be signed in to change notification settings - Fork 4k
Fix DateTimeExtraction model - Bug Fix #9364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DateTimeExtraction model - Bug Fix #9364
Conversation
...ts/OperationalInsights/Models/DataSourcePropertiesPerKind/PSCustomLogDataSourceProperties.cs
Outdated
Show resolved
Hide resolved
Also, please add a changelog entry under src\Monitor\Monitor for this |
sure |
@arolshan Please respond - if this is a model that is part of cmdlet output (or input), then removing a property is a breaking change. Also, it is unclear to me how this property would be populated, can you explain? If something has changed in the underlying API, then you need to mitigate the break, which would mean keeping the current string property, adding a new property with the new value, and ensuring that the properties are populated by the cmdlet. Adding a CmdletBreakingChangeAttribute to the model property. |
...ts/OperationalInsights/Models/DataSourcePropertiesPerKind/PSCustomLogDataSourceProperties.cs
Outdated
Show resolved
Hide resolved
- add json converter for json read. backward compatibility in case regex string is input. - add cmdlet breaking change attribute. - add tests
changing this would be breaking change. Thats how the model is in the backend server
Description
Checklist
CONTRIBUTING.md
platyPS
module