Skip to content

Fix DateTimeExtraction model - Bug Fix #9364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

arolshan
Copy link
Contributor

@arolshan arolshan commented Jun 5, 2019

Description

Checklist

@arolshan arolshan requested a review from cormacpayne June 5, 2019 11:00
@arolshan arolshan changed the title Update PSCustomLogDataSourceProperties.cs Fix DateTimeExtraction model Jun 5, 2019
@arolshan arolshan closed this Jun 5, 2019
@arolshan arolshan reopened this Jun 5, 2019
@markcowl
Copy link
Member

markcowl commented Jun 5, 2019

Also, please add a changelog entry under src\Monitor\Monitor for this

@arolshan
Copy link
Contributor Author

arolshan commented Jun 6, 2019

Also, please add a changelog entry under src\Monitor\Monitor for this

sure

@arolshan arolshan requested a review from markcowl June 6, 2019 07:54
@markcowl
Copy link
Member

markcowl commented Jun 7, 2019

@arolshan Please respond - if this is a model that is part of cmdlet output (or input), then removing a property is a breaking change. Also, it is unclear to me how this property would be populated, can you explain?

If something has changed in the underlying API, then you need to mitigate the break, which would mean keeping the current string property, adding a new property with the new value, and ensuring that the properties are populated by the cmdlet. Adding a CmdletBreakingChangeAttribute to the model property.

@arolshan arolshan requested a review from markcowl June 10, 2019 12:47
@arolshan arolshan dismissed markcowl’s stale review June 17, 2019 18:22

changing this would be breaking change. Thats how the model is in the backend server

@arolshan arolshan changed the title Fix DateTimeExtraction model Fix DateTimeExtraction model - BugFix Jun 19, 2019
@arolshan arolshan changed the title Fix DateTimeExtraction model - BugFix Fix DateTimeExtraction model - Bug Fix Jun 19, 2019
@markcowl markcowl merged commit 146c409 into Azure:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants