-
Notifications
You must be signed in to change notification settings - Fork 4k
Added Better Error Handling #9403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiYanni
suggested changes
Jun 12, 2019
src/Peering/Peering/Direct/SetAzureDirectPeeringConnectionCommand.cs
Outdated
Show resolved
Hide resolved
src/Peering/Peering/Direct/SetAzureDirectPeeringConnectionCommand.cs
Outdated
Show resolved
Hide resolved
src/Peering/Peering/Direct/SetAzureDirectPeeringConnectionCommand.cs
Outdated
Show resolved
Hide resolved
src/Peering/Peering/Exchange/SetAzureExchangePeeringConnectionCommand.cs
Outdated
Show resolved
Hide resolved
src/Peering/Peering/Exchange/SetAzureExchangePeeringConnectionCommand.cs
Outdated
Show resolved
Hide resolved
rileymckenna
commented
Jun 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MiYanni I sent you a message on teams, the reason i changed from is
to GetType() was because of a null reference error. The object that came in would have two of each field and i couldnt figure out how to get rid of the duplicate field of select the correct field.
src/Peering/Peering/Direct/SetAzureDirectPeeringConnectionCommand.cs
Outdated
Show resolved
Hide resolved
MiYanni
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Errors were not being displayed properly between the ARM error and ERM error.
Added some verbose statements to assist in troubleshooting
Removed squashing of connections validations
Fixed validation of IP Prefixes
Checklist
CONTRIBUTING.md
platyPS
module