Skip to content

Replace "wps_2" with "Windows PowerShell" #9438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Conversation

Jaykul
Copy link
Contributor

@Jaykul Jaykul commented Jun 17, 2019

Description

This updates New-AzAutomationDocument, there may be others -- I will follow up and update the PR, but I have a question:

We could probably just say "PowerShell" (which would make this a little more future proof) but I'm reasonably sure these Automation accounts are using Windows PowerShell 5.1 indefinitely, and not PowerShell Core 6 -- is that true?

Further, upon reading the checklist below, I'm not sure if this is the right place to update these...

Checklist

This updates New-AzAutomationDocument, there may be others.
We could probably just use "PowerShell" but I'm reasonably sure these Automation accounts are using Windows PowerShell 5.1, not PowerShell Core 6
@cormacpayne
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@cormacpayne
Copy link
Member

@Jaykul Hey Joel, thanks for the PR 😀

@vrdmr Hey Varad, would you mind confirming the statement made above by @Jaykul and sign-off on the changes made in this PR?

@cormacpayne
Copy link
Member

@vrdmr ping

@markcowl markcowl merged commit d47d4e3 into Azure:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants