Skip to content

Add new cmdlets and features to support PrivateIP #9443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2019
Merged

Add new cmdlets and features to support PrivateIP #9443

merged 2 commits into from
Jul 23, 2019

Conversation

bowen0106
Copy link
Contributor

@bowen0106 bowen0106 commented Jun 17, 2019 •
edited
Loading

Description

Add new cmdlets

  • Set-AzPrivateEndpoint
  • Set-AzPrivateLinkService
  • Approve-AzPrivateEndpointConnection
  • Deny-AzPrivateEndpointConnection
  • Get-AzPrivateEndpointConnection
  • Remove-AzPrivateEndpointConnection
  • Test-AzPrivateLinkServiceVisibility
  • Get-AzAutoApprovedPrivateLinkService

Update cmdlets
Added optional parameters PrivateEndpointNetworkPolicies/PrivateLinkServiceNetworkPolicies on Subnet in Virtualnetwork

  • New-AzVirtualNetworkSubnetConfig
  • Set-AzVirtualNetworkSubnetConfig
  • Add-AzVirtualNetworkSubnetConfig

Checklist

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@cormacpayne
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

cormacpayne
cormacpayne previously requested changes Jun 18, 2019
View reviewed changes
Copy link
Member

@cormacpayne cormacpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bowen0106 some comments about the build failure to take a look at.

Also, has a cmdlet review been accepted for the changes being made in this PR? If so, please add a link to the design review so we know which review to have assigned to this PR. If not, please create a new issue in the following repository:

https://github.com/Azure/azure-powershell-cmdlet-review-pr

@bowen0106
Copy link
Contributor Author

The cmdlet review is here: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/324

@EvgenyAgafonchikov
Copy link
Contributor

@bowen0106, please place SDK package to LocalFeed to avoid extra CI failures. Alternatively you may wait for official release if milestones allows to do it.

@markcowl markcowl closed this Jul 12, 2019
@markcowl markcowl reopened this Jul 12, 2019
@markcowl
Copy link
Member

@bowen0106 Please respond to the latest review comments on your design review issue. Also, please fix merge conflicts

@markcowl
Copy link
Member

/azp run azure-powershell - windows-powershell

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@markcowl
Copy link
Member

@bowen Can you fix the build issues please? This PR has been open for a month. SHould we close it until your branch is ready?

@anton-evseev anton-evseev mentioned this pull request Jul 22, 2019
Merged
8 tasks
@anton-evseev
Copy link
Contributor

Test failures are due to API version change, rely on this PR: #9698
Cmdlet Review was passed: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/324
@markcowl please take a look

@anton-evseev anton-evseev assigned markcowl and unassigned bowen0106 Jul 22, 2019
@MiYanni
Copy link
Contributor

MiYanni commented Jul 22, 2019

@bowen0106 You have merge conflicts.

@markcowl markcowl assigned bowen0106 and unassigned markcowl Jul 22, 2019
@MikhailTryakhov
Copy link
Contributor

Closed due to release time

@anton-evseev anton-evseev reopened this Jul 22, 2019
@anton-evseev
Copy link
Contributor

@MiYanni resolved conflicts, could you please take a look? Hopefully we can get this into #9704

@anton-evseev anton-evseev assigned MiYanni and unassigned bowen0106 Jul 22, 2019
@MikhailTryakhov
Copy link
Contributor

Excluded due to some properties and parameter names were changed. The properties must remain the same names. The parameters could change with an alias to the prior name
@bowen0106 please change names to the exactly the same as we had previously and merge it to the next monthly branch. currently closing

@MiYanni MiYanni reopened this Jul 23, 2019
@MiYanni MiYanni changed the base branch from network-may to network-july July 23, 2019 01:17
@anton-evseev anton-evseev force-pushed the bowen/network-may-pe branch 2 times, most recently from 99abb58 to 0b1a780 Compare July 23, 2019 09:42
@anton-evseev anton-evseev force-pushed the bowen/network-may-pe branch from c88bae5 to 2ca8bfa Compare July 23, 2019 13:51
@anton-evseev
Copy link
Contributor

anton-evseev commented Jul 23, 2019 •
edited
Loading

Resolved issues with breaking changes by adding aliases and proxy properties. Left one entry in BreakingChanges.csv since it's a bug fix, not a breaking change.

@anton-evseev
Copy link
Contributor

@MiYanni all green, please take a look

@MiYanni MiYanni changed the base branch from network-july to master July 23, 2019 17:31
@MiYanni MiYanni dismissed cormacpayne’s stale review July 23, 2019 17:53

Comments have been addressed

@MiYanni MiYanni merged commit 6df8123 into Azure:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiYanni MiYanni MiYanni approved these changes

@cormacpayne cormacpayne cormacpayne left review comments

@EvgenyAgafonchikov EvgenyAgafonchikov Awaiting requested review from EvgenyAgafonchikov

Assignees

@MiYanni MiYanni

Labels
Cmdlet Review Complete needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bowen0106 @adxsdkps @cormacpayne @EvgenyAgafonchikov @markcowl @anton-evseev @MiYanni @MikhailTryakhov @azuresdkci