Skip to content

[Storage] Support File AAD Domain Service Authentication GA #9465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 24, 2019

Conversation

blueww
Copy link
Member

@blueww blueww commented Jun 19, 2019

Description

Design pass review in https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/320

Checklist

@blueww blueww changed the title [Storage] Support FileAAd GA [Storage] Support File AAD Domain Service Authentication GA Jun 19, 2019
@markcowl
Copy link
Member

@cormacpayne, please fix the solution for EventGrid

@blueww
Copy link
Member Author

blueww commented Jun 20, 2019

@markcowl@cormacpayne
I have rebase the code on laster master, and rerun the PR checks.

Now only Mac test fail, the failure is also on EventGrid.
Let me know if you need any information from me for the fix.

Feature team target this for 7/2 release, and hope we won't miss it since the next one will be 1 month later.

@blueww
Copy link
Member Author

blueww commented Jun 21, 2019

@cormacpayne , @markcowl
I merged latest master branch to the PR, and add another fix for EventGrid Test beaaf55. (The fix is similar to Cormac's fix e9fe86b )

The build check pass now.
Would you please help to review the PR ASAP, and merge it if no other comments?

@markcowl markcowl merged commit e1491ea into Azure:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants