Skip to content

Add optional ResourceGroupName to LTR cmdlet #9703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 5, 2019
Merged

Add optional ResourceGroupName to LTR cmdlet #9703

merged 10 commits into from
Aug 5, 2019

Conversation

pixia
Copy link
Contributor

@pixia pixia commented Jul 22, 2019

Description

Checklist

johnpaulkee
johnpaulkee previously approved these changes Jul 22, 2019
Copy link
Contributor

@johnpaulkee johnpaulkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, just some suggestions to use ResourceIdentifier class to parse resource id.

@pixia
Copy link
Contributor Author

pixia commented Jul 22, 2019

Approved, just some suggestions to use ResourceIdentifier class to parse resource id.

As discussed offline, ResourceIdentifier does not fit my needs. Will stick to the current implementation.

@cormacpayne
Copy link
Member

@pixia some of the Sql tests are failing as a part of this PR -- would you mind taking a look?

@cormacpayne cormacpayne dismissed markcowl’s stale review August 5, 2019 22:45

Comments addressed

@cormacpayne cormacpayne merged commit 824e7aa into Azure:master Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants