-
Notifications
You must be signed in to change notification settings - Fork 4k
Add optional ResourceGroupName to LTR cmdlet #9703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, just some suggestions to use ResourceIdentifier class to parse resource id.
src/Sql/Sql/Database Backup/Cmdlet/RemoveAzureRmSqlDatabaseLongTermRetentionBackup.cs
Show resolved
Hide resolved
As discussed offline, ResourceIdentifier does not fit my needs. Will stick to the current implementation. |
src/Sql/Sql/Database Backup/Cmdlet/RemoveAzureRmSqlDatabaseLongTermRetentionBackup.cs
Outdated
Show resolved
Hide resolved
src/Sql/Sql/Database Backup/Cmdlet/GetAzureRmSqlDatabaseLongTermRetentionBackup.cs
Outdated
Show resolved
Hide resolved
@pixia some of the Sql tests are failing as a part of this PR -- would you mind taking a look? |
Description
Checklist
CONTRIBUTING.md
platyPS
module