Fix hanging of Get-DataLakeStoreDeletedItem for any errors or remote exceptions #9706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akharit
previously approved these changes
Jul 23, 2019
akaguptams
previously approved these changes
Jul 23, 2019
cormacpayne
suggested changes
Jul 29, 2019
src/DataLakeStore/DataLakeStore/DataPlaneModels/DataLakeStoreFileSystemClient.cs
Show resolved
Hide resolved
cormacpayne
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Earlier for any errors or exceptions, Get-DataLakeStoreDeletedItem used to hang. The reason is the finishing of the task depended on a flag set in the progresstracker. However if a error occurs the progresstracker wont be updated so it will be on an infinite loop.
Checklist
CONTRIBUTING.mdplatyPSmodule