Skip to content

Inbound NAT pools PowerShell changes. #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 30, 2015
Merged

Conversation

ankurchoubeymsft
Copy link
Contributor

PowerShell commands and model changes for configuring inbound NAT pools on the load balancer. Test cases for inbound NAT pools and their corresponding SessionRecords. Updating package version for Microsoft.Azure.Management.Network. Fixed a few minor typos.

PowerShell commands and model changes for configuring inbound NAT pools on the load balancer. Test cases for inbound NAT pools and their corresponding SessionRecords. Updating package version for Microsoft.Azure.Management.Network. Fixed a few minor typos.
@azuresdkci
Copy link

Can one of the admins verify this patch?

@azurecla
Copy link

Hi @ankurchoubeymsft, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@markcowl
Copy link
Member

@azuresdkci add to whitelist

@DeepakRajendranMsft
Copy link
Contributor

can we kick off the job again, seems to be a test timeout issue in azure backup
D:\workspace\powershell\AzurePowershell.test.targets(100,5): error : XUnit tests in assembly "Microsoft.Azure.Commands.AzureBackup.Test.dll" failed or timed out. Ensure that all tests in a project pass and collectively take less than 1 minute to run. [D:\workspace\powershell\build.proj]

@stankovski
Copy link
Member

@azuresdkci retest this please

@azuresdkci
Copy link

Can one of the admins verify this patch?

1 similar comment
@azuresdkci
Copy link

Can one of the admins verify this patch?

$frontend = New-AzureRMLoadBalancerFrontendIpConfig -Name $frontendName -SubnetId $vnet.Subnets[0].Id
New-AzureRMLoadBalancer -Name $lbName -ResourceGroupName $rgname -Location $location -FrontendIpConfiguration $frontend

$lb = Get-AzureRMLoadBalancer -Name $lbName -ResourceGroupName $rgname
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: cmdlets should be AzureRmXXX

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in the latest commit. (ankurchoubeymsft@e6cb77a)

@ankurchoubeymsft
Copy link
Contributor Author

Addressed code review comments. New build succeeded and all tests passed. Can one of the admins retest/verify the pull request.

stankovski added a commit that referenced this pull request Sep 30, 2015
Inbound NAT pools PowerShell changes.
@stankovski stankovski merged commit cbd9c6d into Azure:dev Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants