-
Notifications
You must be signed in to change notification settings - Fork 4k
Inbound NAT pools PowerShell changes. #973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PowerShell commands and model changes for configuring inbound NAT pools on the load balancer. Test cases for inbound NAT pools and their corresponding SessionRecords. Updating package version for Microsoft.Azure.Management.Network. Fixed a few minor typos.
Can one of the admins verify this patch? |
Hi @ankurchoubeymsft, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
@azuresdkci add to whitelist |
can we kick off the job again, seems to be a test timeout issue in azure backup |
@azuresdkci retest this please |
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
$frontend = New-AzureRMLoadBalancerFrontendIpConfig -Name $frontendName -SubnetId $vnet.Subnets[0].Id | ||
New-AzureRMLoadBalancer -Name $lbName -ResourceGroupName $rgname -Location $location -FrontendIpConfiguration $frontend | ||
|
||
$lb = Get-AzureRMLoadBalancer -Name $lbName -ResourceGroupName $rgname |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: cmdlets should be AzureRmXXX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in the latest commit. (ankurchoubeymsft@e6cb77a)
Rename cmdlets to AzureRm* instead of AzureRM* for Inbound NAT pool cmdlets and corresponding test cases
Addressed code review comments. New build succeeded and all tests passed. Can one of the admins retest/verify the pull request. |
Inbound NAT pools PowerShell changes.
PowerShell commands and model changes for configuring inbound NAT pools on the load balancer. Test cases for inbound NAT pools and their corresponding SessionRecords. Updating package version for Microsoft.Azure.Management.Network. Fixed a few minor typos.