Update to R4.5 RP standard (#24) #9762
Conversation
* NFSAAS-2898 update to R4.5 RP standard * NFSAAS-2898 update to R4.5 RP standard
|
@niander or @cormacpayne static analysis still fails despite adding the breaking changes file (as detailed in the old PR that this one replaced, #9680) |
* NFSAAS-2898 update to R4.5 RP standard * NFSAAS-2898 update to R4.5 RP standard * NFSAAS-2898 update to R4.5 RP standard
|
Static analysis now fixed. But core Test Windows has a failure. Please advise on that. Well, there is a test failure, maybe related to that. |
|
The problem was from test failure. Note that I have now commented out this test. It fails in the playback mode despite no changes. I'm unable to record a new one due to external setup required in the subscription, which I always expected to be a problem. |
Update active directory test
Add test back in. New test record available.
|
I was able to record the failing test again and added it back in. Review required. |
|
Any chance of a review soon. This is quite overdue for the ANF R4.5 GA release. Thanks. |
There was a problem hiding this comment.
Sorry for late response, here are my general opinions
- Please make sure to check all the checklist if applicable before requesting a review
- Please provide a more clearer title and description. For example, an internal ticket number in the title doesn't help reviewer understand your intentions
leonardbf
changed the title
|
@isra-fel ready for re-review. Thanks. |
There was a problem hiding this comment.
@leonardbf a couple of minor comments, otherwise LGTM
@isra-fel anything else that needs to be changed from what you can see?
|
Nothing more from my side @cormacpayne , thank you 👍 |
|
Any chance of re-review and maybe merge? Thanks. |
cormacpayne
dismissed
isra-fel’s stale review
Comments addressed and signed-off on
Supercedes #9680
Addition of ProtocolType and MountTarget
Internal ticket NFSAAS-2898
Description
Checklist
CONTRIBUTING.mdplatyPSmodule