Skip to content

Deprecating Add-AzServiceFabricApplicationCertificate cmdlet #9825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2019
Merged

Deprecating Add-AzServiceFabricApplicationCertificate cmdlet #9825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a1c605
marking add app cert to be deprecated
Aug 13, 2019
af83656
fix CmdletDeprecation annotation
Aug 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ServiceFabric/ServiceFabric/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
* Fix add node type cmdlet bugs:
- NullReferenceException bug when resource group had other vmss not related to the service fabric cluster. Fixes issue: https://github.com/Azure/azure-powershell/issues/8681
- Fix bug where cmdlet failed if virtualNetwork was in a different resource group that the cluster. fixes issue: https://github.com/Azure/azure-powershell/issues/8407
- Deprecating Add-AzServiceFabricApplicationCertificate cmdlet

## Version 1.1.1
* Fix add certificate ByExistingKeyVault getting the wrong thumbprint in some cases
Expand Down
5 changes: 5 additions & 0 deletions src/ServiceFabric/ServiceFabric/Commands/AddAzureRmServiceFabricApplicationCertificate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,14 @@
using Microsoft.Azure.Commands.ServiceFabric.Models;
using ServiceFabricProperties = Microsoft.Azure.Commands.ServiceFabric.Properties;
using Microsoft.Azure.Commands.Common.Compute.Version_2018_04;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;

namespace Microsoft.Azure.Commands.ServiceFabric.Commands
{
[CmdletDeprecation(ReplacementCmdletName = VerbsCommon.Add +
"-" +
ResourceManager.Common.AzureRMConstants.AzureRMPrefix +
"VmssSecret")]
[Cmdlet("Add", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "ServiceFabricApplicationCertificate", SupportsShouldProcess = true), OutputType(typeof(PSKeyVault))]
public class AddAzureRmServiceFabricApplicationCertificate : ServiceFabricClusterCertificateCmdlet
{
Expand Down