Skip to content

Add an option to skip MD5 computation and checking. Also disable MD5 … #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2015

Conversation

iouri-s
Copy link
Contributor

@iouri-s iouri-s commented Sep 28, 2015

…computation when using HTTPS because it is redundant.

MD5 computation takes about half the time required for uploading a VHD and it is rarely useful. Its main purpose is to protect users from themselves, e.g. by disallowing a restart of an interrupted upload with a VHD that is not the same as the one used originally. Skipping the computation offers a 50% speed improvement in real life testing.

…computation when using HTTPS because it is redundant.
@azuresdkci
Copy link

Can one of the admins verify this patch?

@azurecla
Copy link

Hi @iouri-s, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@hovsepm
Copy link
Contributor

hovsepm commented Sep 28, 2015

@azuresdkci test this please

1 similar comment
@stankovski
Copy link
Member

@azuresdkci test this please

@azuresdkci
Copy link

Can one of the admins verify this patch?

1 similar comment
@azuresdkci
Copy link

Can one of the admins verify this patch?

stankovski added a commit that referenced this pull request Sep 29, 2015
Add an option to skip MD5 computation and checking. Also disable MD5 …
@stankovski stankovski merged commit 31d9ac0 into Azure:dev Sep 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants