Remove unused assembly symbol access

[chsienki]

Removes an unneeded assembly symbol access in the generator, which has a performance penalty.

[github-actions]

Thank you for your contribution @chsienki! We will review the pull request and get back to you soon.

[Copilot]

Pull Request Overview

Removes an unused assembly symbol lookup from the generator pipeline to reduce performance overhead.

• Eliminates the assemblyNameProvider and its Combine step.
• Updates the tuple shape in the Combine.Select and signature of ReportDiagnosticAndEmitSource.
• Removes extraction of data.Assembly.Name.

Comments suppressed due to low confidence (2)

sdk/core/System.ClientModel/gen/ModelReaderWriterContextGenerator.cs:95

• [nitpick] The current Combine.Select chain uses deeply nested tuple deconstruction (data.Left.Left...). Consider deconstructing the combined tuple into named local variables or introducing a small record type to flatten the data for better readability.

.Select((data, _) => (

sdk/core/System.ClientModel/gen/ModelReaderWriterContextGenerator.cs:148

• [nitpick] Since the Assembly tuple element was removed, the data tuple now has shifted positions. Consider deconstructing data in the method signature of ReportDiagnosticAndEmitSource to give each element a descriptive name rather than accessing them via data. properties.

var contextType = data.SymbolToTypeRefCache.Get(contextSymbol, data.SymbolToKindCache);