[Storage] Fix listener to use the target data blob client over the host #50431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amnguye
requested review from
seanmcc-msft,
jaschrep-msft,
tg-msft,
fabiocav,
mathewc,
jalauzon-msft and
nickliu-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the blob listener was incorrectly using the host blob client instead of the target data blob client.
- Updated the registration call in BlobListenerFactory to use targetBlobClient over primaryBlobClient.
- Addresses the issue detailed in [QUERY] Blob Trigger Function App: Will LogScan happen when it is connecting to a 2nd storage account? #49993.
Comments suppressed due to low confidence (1)
sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/Listeners/BlobListenerFactory.cs:110
- Replacing primaryBlobClient with targetBlobClient ensures that the listener is monitoring the correct data blob client, which resolves the reported issue. Please verify that other related instances of the primaryBlobClient usage have been updated accordingly if they are related to this context.
await RegisterWithSharedBlobListenerAsync(hostId, sharedBlobListener, targetBlobClient,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49993