Remove Utf8JsonWriterExtensions.WriteObjectValue extension method #50509
+1,650
−278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lementTests.cs Co-authored-by: Copilot <[email protected]>
…mentJsonConverter.cs Co-authored-by: Copilot <[email protected]>
live1206
changed the title
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
live1206
commented
Jun 10, 2025
| }; | ||
|
|
||
| [Test, TestCaseSource("ObjectCases")] | ||
| public static void WriteObjectValue (object value, string expectedJson) |
There was a problem hiding this comment.
The implementation is removed in this PR, remove the test as well
|
pending on #50447 |
sdk/core/Azure.Core.Expressions.DataFactory/src/DataFactoryElement.Serialization.cs
Outdated
Show resolved
Hide resolved
| @@ -55,7 +55,7 @@ public static RequestContent FromDictionary<T>(IDictionary<string, T> dictionary | |||
| foreach (var item in dictionary) | |||
| { | |||
| content.JsonWriter.WritePropertyName(item.Key); | |||
| content.JsonWriter.WriteObjectValue(item.Value); | |||
There was a problem hiding this comment.
This is not a test usage.
There was a problem hiding this comment.
This file has been generated for each RP, the only usage is in test, move it to test project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #50508