[KeyVault] Update Keys with service version 7.6 #50510
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanCrd
changed the title
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
chlowell
reviewed
Jun 10, 2025
Comment on lines
+64
to
+65
| /// <summary> | ||
| /// Gets a 256-bit CKM AES Key Wrap <see cref="KeyWrapAlgorithm"/>. |
There was a problem hiding this comment.
Suggested change
| /// <summary> | |
| /// Gets a 256-bit CKM AES Key Wrap <see cref="KeyWrapAlgorithm"/>. | |
| /// <summary> | |
| /// Gets a 256-bit CKM AES Key Wrap <see cref="KeyWrapAlgorithm"/>. |
chlowell
reviewed
Jun 10, 2025
Comment on lines
+21
to
+22
| public static readonly AesKw CkmAesKeyWrap = new AesKw("CKM_AES_KEY_WRAP", 192); | ||
| public static readonly AesKw CkmAesKeyWrapPad = new AesKw("CKM_AES_KEY_WRAP_PAD", 256, PaddingMode.PKCS7); |
There was a problem hiding this comment.
Why these fixed sizes? MHSM supports 128-bit symmetric keys and, to my knowledge, so do these algorithms. And how does PKCS7 padding work here? RFC 5649 describes a different padding method.
There was a problem hiding this comment.
For the ones withouth paddings, I missed the other 2 possible values here: 128 and 256; Adding them.
Regarding the padding, yeah this is incorrect, I should not be using PKCS7. I got confused when I added these properties into the EncryptionAlgorithms class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the comments on this API VIEW by moving the
CkmAesKeyWrapalgorithm toKeyWrapAlgorithm.Additionally, this PR replaces preview version
7.6-preview.2with7.6.