Skip to content

adding ai agents instrumentation #40866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

M-Hietala
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Copilot Copilot AI review requested due to automatic review settings May 2, 2025 18:28
@github-actions github-actions bot added the Monitor - Distro Monitor OpenTelemetry Distro label May 2, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds additional instrumentation support for AI agents by updating the list of instrumentors.

  • Add instrumentation entry for module "azure.ai.agents.telemetry"
  • Retain existing instrumentation for "azure.ai.projects.telemetry.agents"
Comments suppressed due to low confidence (1)

sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_configure.py:285

  • [nitpick] Both entries for AI agent instrumentation use the same class name 'AIAgentsInstrumentor'. Confirm that these two modules are intended to use identical instrumentation logic without causing conflicts; if there are differences, consider renaming one for clarity.
        ("azure.ai.agents.telemetry", "AIAgentsInstrumentor"),

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@M-Hietala M-Hietala requested a review from lmolkova May 5, 2025 14:06
@lzchen
Copy link
Member

lzchen commented May 5, 2025

@hectorhdzg

Copy link
Member

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any chance you can update the CHANGELOG?

@M-Hietala M-Hietala merged commit 05e9aac into main May 9, 2025
28 checks passed
@M-Hietala M-Hietala deleted the m-hietala/adding_agents_instumentation branch May 9, 2025 17:20
@Copilot Copilot AI mentioned this pull request May 9, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monitor - Distro Monitor OpenTelemetry Distro
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants