Skip to content

Commit 57406d2

Browse files
committed
Address PR feedback
1 parent a68d5c8 commit 57406d2

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/AbstractApplicationBase.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public abstract class AbstractApplicationBase implements IApplicationBase {
3232
private IHttpClient httpClient;
3333
private Integer connectTimeoutForDefaultHttpClient;
3434
private Integer readTimeoutForDefaultHttpClient;
35-
private boolean disableInternalRetries;
35+
private boolean retryDisabled;
3636
String tenant;
3737

3838
//The following fields are set in only some applications and/or set internally by the library. To avoid excessive
@@ -151,8 +151,8 @@ public Integer readTimeoutForDefaultHttpClient() {
151151
return this.readTimeoutForDefaultHttpClient;
152152
}
153153

154-
boolean retriesDisabled() {
155-
return this.disableInternalRetries;
154+
boolean isRetryDisabled() {
155+
return this.retryDisabled;
156156
}
157157

158158
String tenant() {
@@ -374,7 +374,7 @@ private static Authority createDefaultAADAuthority() {
374374
readTimeoutForDefaultHttpClient = builder.readTimeoutForDefaultHttpClient;
375375
authenticationAuthority = builder.authenticationAuthority;
376376
clientId = builder.clientId;
377-
disableInternalRetries = builder.disableInternalRetries;
377+
retryDisabled = builder.disableInternalRetries;
378378

379379
if (builder.httpClient == null) {
380380
httpClient = new DefaultHttpClient(

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/HttpHelper.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class HttpHelper implements IHttpHelper {
2626

2727
private IHttpClient httpClient;
2828
private IRetryPolicy retryPolicy;
29-
private boolean retriesDisabled;
29+
private boolean retryDisabled;
3030

3131
HttpHelper(IHttpClient httpClient, IRetryPolicy retryPolicy) {
3232
this.httpClient = httpClient;
@@ -35,7 +35,7 @@ class HttpHelper implements IHttpHelper {
3535

3636
HttpHelper(AbstractApplicationBase application, IRetryPolicy retryPolicy) {
3737
this.httpClient = application.httpClient();
38-
this.retriesDisabled = application.retriesDisabled();
38+
this.retryDisabled = application.isRetryDisabled();
3939
this.retryPolicy = retryPolicy != null ? retryPolicy : new DefaultRetryPolicy();
4040
}
4141

@@ -152,7 +152,7 @@ IHttpResponse executeHttpRequestWithRetries(HttpRequest httpRequest, IHttpClient
152152
throws Exception {
153153
IHttpResponse httpResponse = httpClient.send(httpRequest);
154154

155-
if (retriesDisabled) {
155+
if (retryDisabled) {
156156
return httpResponse;
157157
}
158158

0 commit comments

Comments
 (0)