Skip to content

Enable device code flow for ADFS 2019 #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 2, 2020
Merged

Enable device code flow for ADFS 2019 #241

merged 5 commits into from
Jun 2, 2020

Conversation

Avery-Dunn
Copy link
Collaborator

Allows device code flow to for ADFS users, per #237

  • Adds device code endpoint parameter to Authority objects
  • Changes device code's HTTP request from GET to POST, moves query parameters to body
  • Adds integration test for device code with ADFS user, removes unit tests looking for exception in that situation

@Avery-Dunn Avery-Dunn requested review from SomkaPe and sangonzal May 29, 2020 19:09
SomkaPe
SomkaPe reviewed Jun 1, 2020
View reviewed changes
sangonzal
sangonzal suggested changes Jun 1, 2020
View reviewed changes
SomkaPe
SomkaPe reviewed Jun 2, 2020
View reviewed changes
sangonzal
sangonzal reviewed Jun 2, 2020
View reviewed changes
@Avery-Dunn Avery-Dunn requested a review from sangonzal June 2, 2020 20:25
sangonzal
sangonzal approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@sangonzal sangonzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

src/main/java/com/microsoft/aad/msal4j/ADFSAuthority.java
}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra line

@Avery-Dunn Avery-Dunn merged commit df4e339 into dev Jun 2, 2020
@Avery-Dunn Avery-Dunn deleted the avdunn/adfs-devicecode branch October 13, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SomkaPe SomkaPe SomkaPe approved these changes

@sangonzal sangonzal sangonzal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Avery-Dunn @SomkaPe @sangonzal