-
Notifications
You must be signed in to change notification settings - Fork 148
Allow client assertion to be a callback and a per-request parameter #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion-library-for-java into avdunn/client-assertion-callback
siddhijain
approved these changes
Mar 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Avery-Dunn
added a commit
that referenced
this pull request
Mar 26, 2022
* fix: Correct scope for test dependency in POM The `azure-security-keyvault-secrets` test dependency was include twice and without the correct `test` scope. * Updated keyvault secrets version * Allow client assertion to be a callback and a per-request parameter (#482) * Allow creating a client assertion from a callback * Allow client credentials as a per-request parameter * Minor changes to fix build issues * Bump version numbers for 1.11.3 release (#484) Co-authored-by: B. Schellhaas <[email protected]> Co-authored-by: Siddhi <[email protected]>
Avery-Dunn
added a commit
that referenced
this pull request
May 5, 2022
* Initial commit * fix: Correct scope for test dependency in POM The `azure-security-keyvault-secrets` test dependency was include twice and without the correct `test` scope. * Updated keyvault secrets version * Allow client assertion to be a callback and a per-request parameter (#482) * Allow creating a client assertion from a callback * Allow client credentials as a per-request parameter * Minor changes to fix build issues * Bump version numbers for 1.11.3 release (#484) * Revert unintentional commit * Add client_id to http request * Retrigger the build * Moving code to be executed for all client_Assertion requests * Update README.md * Update README.md * Update README.md * Update README.md * Cause the User Principal to be Serializable when held in the HttpSession as an attribute. This allows the J2EE web.xml "distributable" tag to work. https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_application_platform/7.0/html/development_guide/clustering_in_web_applications * Update oauth2-oidc-sdk dependency * Changes in the relevant classes * Update error message when Authority does not contain path * Update IllegalArgumentExceptionMessages.java fix typo * Fix java.io.IOException: too many bytes written (#453) Current implementation relies on system location for getting bytes, and if it is not "UTF-8" underlying outputstream will error with ```java.io.IOException: too many bytes written``` Also fixed minor bug with wrong message being output * Add trailing slash to authorities in silent calls (#431) * Add trailing slash to authorities in silent calls * Move trailing slash helper method to Authority class * Silent calls now use cached environment info (#427) * issue #428 resolution * Fixed failing tests * Updated vulnerable libraries' versions * Revert some changes from the old PR * Update regional endpoints (#504) * Minor fixes/enhancements * Update regional endpoint formatting * Changelog and version changes for 1.12 release (#506) Co-authored-by: siddhijain <[email protected]> Co-authored-by: B. Schellhaas <[email protected]> Co-authored-by: DidunAyodeji <[email protected]> Co-authored-by: Dave Smith (Middleware Support) <[email protected]> Co-authored-by: Matt Mazzola <[email protected]> Co-authored-by: Marcelo Castro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new helper method to the ClientCredentialFactory to create client assertions in a callback, and allows client credentials to be set as a per-request parameter in the client credential flow
As requested in #466