Skip to content

Cloud shell MSI #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 2, 2023
Merged

Cloud shell MSI #713

merged 3 commits into from
Oct 2, 2023

Conversation

neha-bhargava
Copy link
Collaborator

  • Code for cloud shell
  • Unit tests
  • Sample app to test cloud shell

This was linked to issues Sep 19, 2023
[Feature Request] Add Cloud Shell managed identity source to MSI Integration #620
Closed
Document manual testing for cloud shell / service fabric #695
Closed
bgavrilMS
bgavrilMS approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@bgavrilMS bgavrilMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments - needs a small refactoring.

@Avery-Dunn Avery-Dunn self-requested a review September 21, 2023 17:54
@neha-bhargava neha-bhargava merged commit 5f5e32e into nebharg/MSI Oct 2, 2023
@Avery-Dunn Avery-Dunn mentioned this pull request Mar 25, 2024
Merged
@Avery-Dunn Avery-Dunn deleted the nebharg/MsiCloudShell branch July 15, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgavrilMS bgavrilMS bgavrilMS approved these changes

@Avery-Dunn Avery-Dunn Avery-Dunn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document manual testing for cloud shell / service fabric [Feature Request] Add Cloud Shell managed identity source to MSI Integration
3 participants
@neha-bhargava @bgavrilMS @Avery-Dunn