Fix for supplied SSLSocketFactory being ignored #821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was checking if the connection is an instance of ```HttpURLConnection```, but since ```HttpsURLConnection``` extends ```HttpURLConnection``` it's always true and the else is never executed. AzureAD#820
bgavrilMS
approved these changes
May 24, 2024
Avery-Dunn
approved these changes
May 24, 2024
|
Thanks for making this! We have some specific fixes planned for our next release, so if this does not get merged in for that release then it will be part of a hotfix release immediately after. |
|
@bgavrilMS Do I need to do something to get the build to trigger to update the status? |
neha-bhargava
approved these changes
May 29, 2024
|
@Avery-Dunn - any issues with merging this? I don't think it's unit testable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was checking if the connection is an instance of
HttpURLConnection, but sinceHttpsURLConnectionextendsHttpURLConnectionit's always true and the else is never executed.#820