Skip to content

Permit response_mode in get_authorization_request_url #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

blokje
Copy link

@blokje blokje commented Aug 31, 2020

Adds support for response_mode in get_authorization_request_url in order to override the default value set by the authentication server. For example this allows having form_post response in OpenID connect instead of the default fragment.

Adds support for response_mode in get_authorization_request_url in order to override the default value set by the authentication server. For example this allows having form_post response in OpenID connect instead of the default fragment.
@rayluo rayluo added the question label Sep 1, 2020
@rayluo
Copy link
Collaborator

rayluo commented Sep 1, 2020

Hi Rick, thanks for your input here. While the change seems simple, we want to better understand your scenario.

I believe you were using response_type="token" Implicit Flow (which you referred to as "OpenID Connect") and then its default response_mode="fragment" behavior is inconvenient for your Python web app. Therefore you would like to have such change.

But the industry is moving away from Implicit Flow, and change to use Auth Code Flow (i.e. resposne="code"), for security reasons.

If at all possible, we would suggest you to stick with MSAL's default response_type="code" and then you likely do not need to customize its default behavior at all. We have an existing web app sample for that.

@blokje
Copy link
Author

blokje commented Sep 4, 2020

Hi Rayluo,

You are absolutely right and we seemed to. be stuck on some older legacy part of our code. We will take a look if we can integrate the Auth Code Flow. And close this PR as this not the road MSAL is going anyway :-)

Thanks for your feedback and prompt response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants