Skip to content

Precise DeprecationWarning for auth code API #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2021
Merged

Precise DeprecationWarning for auth code API #303

merged 1 commit into from
Feb 2, 2021

Conversation

rayluo
Copy link
Collaborator

@rayluo rayluo commented Jan 30, 2021 •
edited
Loading

Fix #301 by changing the deprecation warning message to:

msal/application.py:446: DeprecationWarning: Change your get_authorization_request_url() to initiate_auth_code_flow()
msal/application.py:581: DeprecationWarning: Change your acquire_token_by_authorization_code() to acquire_token_by_auth_code_flow()

@chlowell Does those wording work for you?

@chlowell
Copy link
Contributor

chlowell commented Feb 1, 2021

Sure, I think that will help people update 👍

@rayluo rayluo merged commit 0fb43c5 into dev Feb 2, 2021
@rayluo rayluo deleted the deprecates-auth-code branch February 2, 2021 02:47
@rayluo rayluo mentioned this pull request Feb 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclear deprecation warnings
2 participants
@rayluo @chlowell