Actionable suggestion for ID token validation failures #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2022
jiasli
reviewed
Jan 14, 2022
| @@ -44,10 +44,11 @@ def decode_id_token(id_token, client_id=None, issuer=None, nonce=None, now=None) | |||
| err = None # https://openid.net/specs/openid-connect-core-1_0.html#IDTokenValidation | |||
| _now = int(now or time.time()) | |||
| skew = 120 # 2 minutes | |||
| TIME_SUGGESTION = "Make sure your computer's time is correctly synchronized." | |||
There was a problem hiding this comment.
Perhaps we also need to mention time zone? The time on the right bottom corner may seem correct, but the time zone may be wrong.
There was a problem hiding this comment.
Good point. I'll change that line to "Make sure your computer's time and time zone are both correct".
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #446 (Note: It turns out a PR can not automatically close a Discussion topic. I'll manually close it there.)