Skip to content

Time suggestion #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2022
Merged

Time suggestion #453

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3df6470
Also hint to check your time zone
rayluo Jan 18, 2022
f047c3a
Merge branch 'time-suggestion' into dev
rayluo Jan 19, 2022
61a4986
Merge remote-tracking branch 'oauth2cli/dev' into time-suggestion
rayluo Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion msal/oauth2cli/oidc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def decode_id_token(id_token, client_id=None, issuer=None, nonce=None, now=None)
err = None # https://openid.net/specs/openid-connect-core-1_0.html#IDTokenValidation
_now = int(now or time.time())
skew = 120 # 2 minutes
TIME_SUGGESTION = "Make sure your computer's time is correctly synchronized."
TIME_SUGGESTION = "Make sure your computer's time and time zone are both correct."
if _now + skew < decoded.get("nbf", _now - 1): # nbf is optional per JWT specs
# This is not an ID token validation, but a JWT validation
# https://tools.ietf.org/html/rfc7519#section-4.1.5
Expand Down