Actionable exception from ADFS username password flow #456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by Azure/azure-cli#21068 (comment) , this PR wraps most "expected" ADFS username password flow into one
RuntimeError
with actionable message.That being said, this actionable message is meant for MSAL's app developer. If you are the app developer, you probably want to catch this
RuntimeError
and translate it into your own exception or error message, for example "... consider use 'az login' instead". @jiasli