Update Powershell auto-generator for Swagger library #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to vmss Conflicts: src/ServiceManagement/Compute/Commands.ServiceManagement.Preview/Generated/cli.js
| }); | ||
| pParameters.Attributes.Add(new AllowNullAttribute()); | ||
| dynamicParameters.Add("VirtualMachineVMImageUpdateParameters", pParameters); | ||
| dynamicParameters.Add("VirtualMachineVMImageUpdateParameter", pParameters); |
There was a problem hiding this comment.
It seems this is impacting the Hyak side. The code generator needs to know about whether it's processing Hyak/AutoRest, and we would still need Hyak for ASM.
There was a problem hiding this comment.
I changed all plural parameter names to singular, to meet the powershell standard. I updated the test code regarding this.
|
Please check the RDFE tests: https://github.com/hyonholee/azure-powershell/blob/vmss/src/ServiceManagement/Common/Commands.ScenarioTest/Resources/ServiceManagement/ServiceManagementTests.ps1#L169 Or try not to change the RDFE side. |
|
LGTM. |
huangpf
added a commit
that referenced
this pull request
Feb 5, 2016
Update Powershell auto-generator for Swagger library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.