Skip to content

Dev #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 43 commits into from
Oct 16, 2015
Merged

Dev #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
aa35f44
Merge pull request #88 from Azure/dev
huangpf Sep 15, 2015
ad974b7
Merge pull request #89 from Azure/dev
huangpf Sep 16, 2015
a38fa2d
Merge pull request #90 from Azure/dev
huangpf Sep 17, 2015
7a97e3a
Merge pull request #91 from Azure/dev
huangpf Sep 17, 2015
5682401
Merge pull request #92 from Azure/dev
huangpf Sep 19, 2015
2c2f082
Merge pull request #93 from Azure/dev
huangpf Sep 20, 2015
a688180
Merge pull request #94 from Azure/dev
huangpf Sep 21, 2015
390ffbe
Merge pull request #95 from Azure/dev
huangpf Sep 21, 2015
39cd7bf
Merge pull request #96 from Azure/dev
huangpf Sep 21, 2015
7e087c9
Merge pull request #99 from Azure/dev
huangpf Sep 22, 2015
84062e0
Merge pull request #100 from AzureRT/dev
huangpf Sep 22, 2015
b9ad912
Merge pull request #110 from Azure/dev
huangpf Sep 25, 2015
0d1d883
Merge pull request #112 from Azure/dev
huangpf Sep 25, 2015
6b38643
Merge pull request #113 from Azure/dev
huangpf Sep 25, 2015
70b9a28
Merge pull request #116 from Azure/dev
huangpf Sep 26, 2015
996ffe3
Merge pull request #118 from Azure/dev
huangpf Sep 28, 2015
95d23d2
Merge pull request #120 from Azure/dev
huangpf Sep 29, 2015
67d29f1
Merge pull request #123 from Azure/dev
huangpf Sep 29, 2015
c2cf2c1
Merge pull request #127 from Azure/dev
huangpf Sep 30, 2015
772da26
Merge pull request #128 from Azure/dev
huangpf Sep 30, 2015
e6246b7
Merge pull request #129 from Azure/dev
huangpf Oct 1, 2015
3305508
Merge pull request #131 from Azure/dev
huangpf Oct 2, 2015
b074625
Merge pull request #132 from Azure/dev
huangpf Oct 2, 2015
cfe09a1
Merge pull request #133 from AzureRT/dev
huangpf Oct 2, 2015
92eac87
Merge pull request #135 from Azure/dev
huangpf Oct 2, 2015
bf104f6
Merge pull request #137 from Azure/dev
huangpf Oct 2, 2015
94641e1
Merge pull request #138 from Azure/dev
huangpf Oct 3, 2015
bfb5796
Merge pull request #139 from Azure/dev
huangpf Oct 5, 2015
02ab411
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
huangpf Oct 5, 2015
ad1aa1c
Merge pull request #140 from Azure/dev
huangpf Oct 6, 2015
a6ca3e7
Merge pull request #141 from Azure/dev
huangpf Oct 6, 2015
9ecd0db
Merge pull request #142 from Azure/dev
huangpf Oct 7, 2015
f2f9f61
Merge pull request #143 from Azure/dev
huangpf Oct 7, 2015
3b08900
Merge pull request #144 from Azure/dev
huangpf Oct 7, 2015
19cba6e
Merge pull request #146 from AzureRT/dev
huangpf Oct 8, 2015
e95f664
Merge pull request #149 from Azure/dev
huangpf Oct 9, 2015
66734fc
Merge pull request #151 from AzureRT/dev
huangpf Oct 9, 2015
b73feb8
Merge pull request #153 from Azure/dev
huangpf Oct 10, 2015
6f2d28f
Merge pull request #154 from Azure/dev
huangpf Oct 13, 2015
a1611e1
Merge pull request #156 from Azure/dev
huangpf Oct 14, 2015
d6c7c2c
Remove Spaces in Extension IDs
huangpf Oct 14, 2015
b2a710b
Merge branch 'dev' of https://github.com/huangpf/azure-powershell int…
huangpf Oct 14, 2015
9b51c08
Merge pull request #160 from AzureRT/dev
huangpf Oct 16, 2015
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@

**********************************************************************************************
-->
<ServiceConfiguration serviceName="AzureCloudService2" xmlns="http://schemas.microsoft.com/ServiceHosting/2008/10/ServiceConfiguration" osFamily="4" osVersion="*" schemaVersion="2015-04.2.6">
<Role name="WebRole1">
<ServiceConfiguration serviceName="WindowsAzure1" xmlns="http://schemas.microsoft.com/ServiceHosting/2008/10/ServiceConfiguration" osFamily="4" osVersion="*" schemaVersion="2014-01.2.3">
<Role name="WebRole1 With Spaces In Name">
<Instances count="1" />
<ConfigurationSettings>
<Setting name="Microsoft.WindowsAzure.Plugins.Diagnostics.ConnectionString" value="UseDevelopmentStorage=true" />
Expand Down
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -564,11 +564,11 @@ function Run-ServiceDeploymentExtensionCmdletTests
}
$cscfg = '.\Resources\ServiceManagement\Files\LongRoleName.Cloud.cscfg';

$webRoleShortName = "WebRole1";
$webRoleNameWithSpaces = "WebRole1 With Spaces In Name";
$workerRoleLongName = "Microsoft.Contoso.Department.ProjectCodeName.Worker";
$rdpCfg1 = New-AzureServiceRemoteDesktopExtensionConfig -Credential $credential -Role $webRoleShortName
$rdpCfg1 = New-AzureServiceRemoteDesktopExtensionConfig -Credential $credential -Role $webRoleNameWithSpaces
$rdpCfg2 = New-AzureServiceRemoteDesktopExtensionConfig -Credential $credential -Role $workerRoleLongName;
$adCfg1 = New-AzureServiceADDomainExtensionConfig -Role $webRoleShortName -WorkgroupName 'test1';
$adCfg1 = New-AzureServiceADDomainExtensionConfig -Role $webRoleNameWithSpaces -WorkgroupName 'test1';
$adCfg2 = New-AzureServiceADDomainExtensionConfig -Role $workerRoleLongName -WorkgroupName 'test2';

$st = New-AzureDeployment -ServiceName $svcName -Package $cspkg -Configuration $cscfg -Label $svcName -Slot Production -ExtensionConfiguration $rdpCfg1,$adCfg1;
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ public ExtensionRole(string roleName)
{
PrefixName = RoleName = roleName.Trim();
PrefixName = PrefixName.Replace(".", string.Empty);
PrefixName = PrefixName.Replace(" ", string.Empty);
RoleType = ExtensionRoleType.NamedRoles;
Default = false;
}
Expand All @@ -62,6 +63,7 @@ public override string ToString()
public string GetExtensionId(string extensionName, string slot, int index)
{
var normalizedExtName = extensionName.Replace(".", string.Empty);
normalizedExtName = normalizedExtName.Replace(" ", string.Empty);

var suffix = new StringBuilder();
suffix.AppendFormat(ExtensionIdSuffixTemplate, normalizedExtName, slot, index);
Expand Down