Skip to content

Remove packages #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Remove packages #66

merged 1 commit into from
Mar 20, 2024

Conversation

csikb
Copy link
Collaborator

@csikb csikb commented Mar 20, 2024

Summary by CodeRabbit

  • Refactor
    • Updated import paths across multiple test files for better project structure organization.
  • Tests
    • Adjusted test cases to reflect updated import paths ensuring continued test reliability.

Copy link
Contributor

coderabbitai bot commented Mar 20, 2024

Walkthrough

The overall change involves a significant restructuring of the project's directory and import paths, moving from a bss_web_file_server namespace to a simpler src namespace. This reorganization affects test files across various categories—models, routers, and services—requiring updates to import paths to align with the new structure. Additionally, there is a minor adjustment in test_main.py, switching from AsyncMock to Mock for specific service mocks.

Changes

Files Summary of Changes
tests/models/test_member.py Updated import path for Member class from ...bss_web_file_server.models.member to src.models.member.
tests/models/test_video.py Import path updated from ...models.video to src.models.video.
tests/routers/test_health.py Updated import path from ...bss_web_file_server.routers to src.routers.
tests/routers/test_member.py
tests/routers/test_video.py
Import paths updated from bss_web_file_server to src for models and routers.
tests/services/test_image.py Updated import path for image module from ...services.image to src.services.image.
tests/services/test_member.py
tests/services/test_video.py
Import paths for Member, MemberService, Video, and VideoService updated from bss_web_file_server to src.
tests/test_main.py Import paths updated from bss_web_file_server to src; AsyncMock to Mock for create_base_path calls.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@csikb csikb added this pull request to the merge queue Mar 20, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 32344bb and ea318ab.
Files ignored due to path filters (3)
  • poetry.lock is excluded by: !**/*.lock
  • pyproject.toml is excluded by: !**/*.toml
  • tests/services/mountains.jpg is excluded by: !**/*.jpg
Files selected for processing (9)
  • tests/models/test_member.py (1 hunks)
  • tests/models/test_video.py (1 hunks)
  • tests/routers/test_health.py (1 hunks)
  • tests/routers/test_member.py (7 hunks)
  • tests/routers/test_video.py (7 hunks)
  • tests/services/test_image.py (1 hunks)
  • tests/services/test_member.py (2 hunks)
  • tests/services/test_video.py (2 hunks)
  • tests/test_main.py (1 hunks)
Files skipped from review due to trivial changes (3)
  • tests/routers/test_health.py
  • tests/routers/test_member.py
  • tests/routers/test_video.py
Additional comments: 9
tests/models/test_member.py (1)
  • 3-3: The updated import path for the Member class aligns with the PR's objectives of reorganizing the project structure. Looks good.
tests/test_main.py (2)
  • 4-4: The updated import path for the main app aligns with the PR's objectives. Good job on maintaining consistency across the project.
  • 8-11: Switching from mocker.AsyncMock() to mocker.Mock() for create_base_path calls is appropriate if the function is indeed synchronous. This change suggests a thoughtful refinement in the mocking strategy.
tests/models/test_video.py (1)
  • 6-6: The updated import path for the Video class is consistent with the PR's objectives of reorganizing the project structure. This looks correct.
tests/services/test_image.py (1)
  • 3-3: The updated import path for the image module correctly reflects the new project structure. Well done.
tests/services/test_member.py (2)
  • 6-7: The updated import paths for Member and MemberService are consistent with the PR's objectives of reorganizing the project structure. This looks correct.
  • 61-61: The adjustment in the import path for create_images within the test function aligns with the PR's objectives. This ensures consistency across the project.
tests/services/test_video.py (2)
  • 6-7: The updated import paths for Video and VideoService correctly reflect the new project structure. This is consistent with the PR's objectives.
  • 64-64: The adjustment in the import path for create_images within the test function is appropriate and ensures consistency across the project.

Merged via the queue into main with commit 9f4606c Mar 20, 2024
@csikb csikb deleted the feature/remove-packages branch March 20, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant