-
Notifications
You must be signed in to change notification settings - Fork 63
New package system #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package system #361
Conversation
Updated windows project settings
Co-authored-by: Ryan Tremblay <[email protected]>
The react-native-iosandroid and react-native-windows have a dependency on react-native with the exact same version. isn't it enough or do you want to check smth else? |
Just tested the changes consuming the generated packages as well as building from the repo: ios package for react native 0.64 - working android app running from repo - working windows app running from repo - working Some users have reported on the forum that they were having the same issue when consuming windows package, I believe this was not caused by the changes in the package system. I will open an issue for us to track this windows package problem.
|
a4ff2aa
to
99cd46a
Compare
react-native-iosandroid
inModules\@babylonjs
that contains ios and android folder. Deps on react-native.react-native
package contains the Shared folder and compiled TS to .js. Dependency on @babylon/core but no deps on nativeMost of the changes are in
gulpfile.js
.You can check the result of publish Action on my repo: https://github.com/CedricGuillemet/BabylonReactNative-1/actions
Package testing:
Download artifacts. zip, unzip then
npm install path\to\unzipped\folder