Skip to content

Package test 0.65.0 #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 14, 2022
Merged

Conversation

CedricGuillemet
Copy link
Contributor

@CedricGuillemet CedricGuillemet commented Apr 13, 2022

  • ios/android/windows generated by react-native scripts
  • metro config changed to support symlink
  • packagetest-shared package containing app.tsx
  • updated package.json w/ bjs deps

Tests:

  • Android
  • iOS
  • Windows

More PRs to come regarding 0.63.1, 0.64.0 and shared folder once this PR is merged.

@CedricGuillemet CedricGuillemet marked this pull request as ready for review April 13, 2022 12:21
Copy link
Member

@ryantrem ryantrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe for a later change, but I think we should get rid of the PackageTest App.tsx, move playground-shared to Apps/playground-shared, add a package.json like you did for packagetest-shared, and use that playground-shared package in all of the Playground apps and all of the PackageTest apps. That way we can test all the various features through one common experience through all the test apps.

@CedricGuillemet
Copy link
Contributor Author

@ryantrem I'm wondering if we should publish the 'test' package containing app.tsx so we won't have to use symlinks and metroconfig would be more readable.

@ryantrem
Copy link
Member

@ryantrem I'm wondering if we should publish the 'test' package containing app.tsx so we won't have to use symlinks and metroconfig would be more readable.

Publish the 'test' package containing app.tsx where? The reason it is setup this way is so that you can make changes to the common code (e.g. App.tsx in this case) and then just run the test apps, without having to worry about building or publishing packages. It makes a much tighter dev inner loop and so the workflow is much more efficient this way.

@CedricGuillemet CedricGuillemet merged commit f92aad5 into BabylonJS:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants