topMost property with perf improvement for Android #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CedricGuillemet
changed the title
CedricGuillemet
changed the title
CedricGuillemet
changed the title
ryantrem
reviewed
Jun 24, 2022
...bylonjs/react-native-iosandroid/android/src/main/java/com/babylonreactnative/EngineView.java
Outdated
Show resolved
Hide resolved
CedricGuillemet
changed the title
ryantrem
reviewed
Jul 7, 2022
...bylonjs/react-native-iosandroid/android/src/main/java/com/babylonreactnative/EngineView.java
Show resolved
Hide resolved
...bylonjs/react-native-iosandroid/android/src/main/java/com/babylonreactnative/EngineView.java
Outdated
Show resolved
Hide resolved
...bylonjs/react-native-iosandroid/android/src/main/java/com/babylonreactnative/EngineView.java
Outdated
Show resolved
Hide resolved
...bylonjs/react-native-iosandroid/android/src/main/java/com/babylonreactnative/EngineView.java
Outdated
Show resolved
Hide resolved
...bylonjs/react-native-iosandroid/android/src/main/java/com/babylonreactnative/EngineView.java
Outdated
Show resolved
Hide resolved
…va/com/babylonreactnative/EngineView.java Co-authored-by: Ryan Tremblay <[email protected]>
ryantrem
reviewed
Jul 12, 2022
...bylonjs/react-native-iosandroid/android/src/main/java/com/babylonreactnative/EngineView.java
Show resolved
Hide resolved
ryantrem
reviewed
Jul 12, 2022
...bylonjs/react-native-iosandroid/android/src/main/java/com/babylonreactnative/EngineView.java
Outdated
Show resolved
Hide resolved
ryantrem
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android, a partner was reporting slow updates/skipped frames when using transparency.
TextureView seems to be famous for being slow.
After some investigation, it's possible to do the same (textureView allows more things that are not usefull in this context) with SurfaceView/SurfaceHolder properties.
Change for iOS/Android. Another PR for Windows will come later.