Enable native camera plugin #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantrem
approved these changes
Jul 26, 2022
|
Here are the build results |
|
Here are the build results |
ryantrem
reviewed
Jul 27, 2022
Modules/@babylonjs/react-native-windows/windows/BabylonReactNative/BabylonReactNative.vcxproj
Outdated
Show resolved
Hide resolved
ryantrem
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables the BN NativeCamera plugin for the BRN project. On Android the NativeCamera plugin uses a compile time check (here) to only support projects targeting a min SDK of 24 or higher. Since BRN includes precompiled binaries for BN that means this change also bumps the BRN playground apps up to min SDK 24 so that the NativeCamera plugin compiles with the proper implementation.
I used the PackageTest projects (which still have a min SDK of 21) to ensure including the pre-compiled binaries against min SDK 24 didn't break anything in the consuming apps.
A better long term fix would be to update the NativeCamera's implementation to use a runtime check of the API level rather than a compile time check.