Use abort controller to prevent async setState after unmount. #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here are the build results |
|
I think technically in this case it is safe to ignore the warning (which as been removed in newer versions of React Native!), but the warning is also noisy and distracting so avoiding it still seems like a good idea to me. |
ryantrem
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Only calls setState if not unmounted. useModuleInitializer was trying to set state in an async fashion, and this must always be accompanied by some cancellation or aborting mechanism in React, otherwise it is possible for a state update to happen on an unmounted component, causing memory leaks and warnings.
Screenshots
N/A
Documentation
N/A
Testing
I need help testing on [Android|iOS|Windows]